Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx77 Move files for HGCAL geometry to match new format #18401

Merged
merged 1 commit into from Apr 20, 2017

Conversation

bsunanda
Copy link
Contributor

Move xml files and modify the appropriate python scripts

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19242/console Started: 2017/04/19 12:59

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HcalCommonData
SimG4CMS/HGCalTestBeam

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18401/19242/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826239
  • DQMHistoTests: Total failures: 15031
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1811035
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Apr 19, 2017

+1
@bsunanda , was this restructure discussed somewhere?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@bsunanda
Copy link
Contributor Author

@civanch Yes it was - I believe this came from David's suggestion and some changes are already made for Muon, Central CMS part by Yana. I am supposed to take care of GEM, HGCAL and HCAL. I am doing this in steps.

@bsunanda
Copy link
Contributor Author

@davidlange6 Can you please merge this - I have to address GEM part next

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 493f57b into cms-sw:master Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants