New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gem27 Move GEM related geometry files in the style suggested by David #18437
Conversation
@cmsbuild Please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @bsunanda for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@@ -14,7 +12,7 @@ | |||
'Geometry/CMSCommonData/data/muonBase.xml', | |||
'Geometry/CMSCommonData/data/cmsMuon.xml', | |||
'Geometry/CMSCommonData/data/mgnt.xml', | |||
'Geometry/CMSCommonData/data/beampipe/2015/v1/beampipe.xml', | |||
'Geometry/CMSCommonData/data/beampipe.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda - I think, you need 2015 beampipe. The other may have overlaps.
'Geometry/MuonCommonData/data/PhaseII/gemf.xml', | ||
'Geometry/MuonCommonData/data/PhaseII/gem11.xml', | ||
'Geometry/MuonCommonData/data/gemf/TDR_BaseLine/gemf.xml', | ||
'Geometry/MuonCommonData/data/gem11/Run2/gem11.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda - Note, that from now on modifications to gemf.xml or gem11.xml will be rejected. Please, move them to a versioned structure to allow further modifications. For example: gem11/2017/v1/gem11.xml
I think this can also cause a conflict with #18373, so whoever is not merged first needs to rebase and rerun the 2023 geometry script |
The tests are being triggered in jenkins. |
Pull request #18437 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
Correct the scenario defining files as well