Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gem27 Move GEM related geometry files in the style suggested by David #18437

Merged
merged 5 commits into from May 3, 2017

Conversation

bsunanda
Copy link
Contributor

Correct the scenario defining files as well

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19318/console Started: 2017/04/21 15:04

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 21, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/HGCalCommonData
Geometry/HcalCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18437/19318/summary.html

Comparison Summary:

  • You potentially added 31 lines to the logs
  • Reco comparison results: 1660 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826205
  • DQMHistoTests: Total failures: 38850
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1787182
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor

+1

@@ -14,7 +12,7 @@
'Geometry/CMSCommonData/data/muonBase.xml',
'Geometry/CMSCommonData/data/cmsMuon.xml',
'Geometry/CMSCommonData/data/mgnt.xml',
'Geometry/CMSCommonData/data/beampipe/2015/v1/beampipe.xml',
'Geometry/CMSCommonData/data/beampipe.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda - I think, you need 2015 beampipe. The other may have overlaps.

'Geometry/MuonCommonData/data/PhaseII/gemf.xml',
'Geometry/MuonCommonData/data/PhaseII/gem11.xml',
'Geometry/MuonCommonData/data/gemf/TDR_BaseLine/gemf.xml',
'Geometry/MuonCommonData/data/gem11/Run2/gem11.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda - Note, that from now on modifications to gemf.xml or gem11.xml will be rejected. Please, move them to a versioned structure to allow further modifications. For example: gem11/2017/v1/gem11.xml

@kpedro88
Copy link
Contributor

I think this can also cause a conflict with #18373, so whoever is not merged first needs to rebase and rerun the 2023 geometry script

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19523/console Started: 2017/05/02 17:46

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Pull request #18437 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented May 2, 2017

@kpedro88 @ianna I have update this PR yet again. Please sign this

@ianna
Copy link
Contributor

ianna commented May 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18437/19523/summary.html

Comparison Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 1670 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831595
  • DQMHistoTests: Total failures: 52689
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1778726
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented May 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0308751 into cms-sw:master May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants