Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of HLT menus (91X) #18460

Merged
merged 5 commits into from Apr 25, 2017
Merged

Update of HLT menus (91X) #18460

merged 5 commits into from Apr 25, 2017

Conversation

silviodonato
Copy link
Contributor

Update of HLT menus.
Sync with /dev/CMSSW_9_0_1/HLT/V28.

@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 25, 2017
@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19375/console Started: 2017/04/25 14:33

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Martin-Grunewald
Copy link
Contributor

What IB is this based on?

@silviodonato
Copy link
Contributor Author

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @silviodonato
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Apr 25, 2017
@silviodonato
Copy link
Contributor Author

It's based on CMSSW_9_1_X_2017-04-24-1100
(I've found an error in hltIntegrationTests)

@cmsbuild
Copy link
Contributor

Pull request #18460 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@silviodonato
Copy link
Contributor Author

unhold

@silviodonato
Copy link
Contributor Author

please abort

@cmsbuild cmsbuild removed the hold label Apr 25, 2017
@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19381/console Started: 2017/04/25 15:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@silviodonato
Copy link
Contributor Author

Updated to /dev/CMSSW_9_0_1/HLT/V29 and ready to be merged.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18460/19381/summary.html

Comparison Summary:

  • You potentially added 203 lines to the logs
  • Reco comparison results: 1657 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1780098
  • DQMHistoTests: Total failures: 54844
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1725081
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 351fd17 into cms-sw:master Apr 25, 2017
@Martin-Grunewald Martin-Grunewald deleted the 91XHLTmenu branch September 7, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants