Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deepCSV to b-tag DQM #18479

Merged

Conversation

swertz
Copy link
Contributor

@swertz swertz commented Apr 26, 2017

This PR adds the new deepCSV tagger (with the four DNN outputs: probb, probc, probusdg, probbb) to the b-tag DQM.

DeepCMVA is also included but left commented out, just as in https://github.com/cms-sw/cmssw/blob/CMSSW_9_1_X/PhysicsTools/PatAlgos/python/producersLayer1/jetProducer_cfi.py#L57

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2017

A new Pull Request was created by @swertz (Sbastien Wertz) for master.

It involves the following packages:

DQMOffline/RecoB

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder, @rociovilar this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19515/console Started: 2017/05/02 15:47

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18479/19515/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1690 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831595
  • DQMHistoTests: Total failures: 56465
  • DQMHistoTests: Total nulls: 45
  • DQMHistoTests: Total successes: 1774905
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1463b2c into cms-sw:master May 3, 2017
@swertz swertz deleted the DQM_deepTaggers-PR_from-CMSSW_9_1_X branch May 3, 2017 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants