New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix HGC recHit energy scale for FTFP_BERT_EMM #18483
Conversation
A new Pull Request was created by @amartelli for master. It involves the following packages: RecoLocalCalo/HGCalRecProducers @perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
This is a fix to the energy scale for HGC rechits after the change in the G4 physics list. Documentation of the study was presented in https://indico.cern.ch/event/607331/contributions/2453642/attachments/1401757/2139714/SimAndPerf_25Jan17.pdf
To be noted that the values fixing the scale (1.174, 1.187, 1.192) were measured on top of what was previously in release (https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/RecoLocalCalo/HGCalRecProducers/python/HGCalRecHit_cfi.py#L82), so the product of the two provides the fix.
A validation with the code from the PR was shown in slide 4 of https://indico.cern.ch/event/619113/contributions/2509419/attachments/1424487/2184573/ClusteringUpdate08March17.pdf