Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix HGC recHit energy scale for FTFP_BERT_EMM #18483

Merged
merged 1 commit into from Apr 29, 2017

Conversation

amartelli
Copy link
Contributor

This is a fix to the energy scale for HGC rechits after the change in the G4 physics list. Documentation of the study was presented in https://indico.cern.ch/event/607331/contributions/2453642/attachments/1401757/2139714/SimAndPerf_25Jan17.pdf

To be noted that the values fixing the scale (1.174, 1.187, 1.192) were measured on top of what was previously in release (https://github.com/cms-sw/cmssw/blob/CMSSW_8_1_X/RecoLocalCalo/HGCalRecProducers/python/HGCalRecHit_cfi.py#L82), so the product of the two provides the fix.

A validation with the code from the PR was shown in slide 4 of https://indico.cern.ch/event/619113/contributions/2509419/attachments/1424487/2184573/ClusteringUpdate08March17.pdf

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @amartelli for master.

It involves the following packages:

RecoLocalCalo/HGCalRecProducers

@perrotta, @cmsbuild, @slava77, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19424/console Started: 2017/04/26 19:12

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18483/19424/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2666 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1783715
  • DQMHistoTests: Total failures: 40998
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1742544
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor

+1
minor changes in high-level quantities for 2023 workflows, as expected

@perrotta
Copy link
Contributor

+1
changes in the energy scale are according to the studies presented

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit bd25d12 into cms-sw:master Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants