Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getcwd() usage to avoid undefined behavior #18485

Merged
merged 1 commit into from Apr 29, 2017

Conversation

dan131riley
Copy link

TFileService::afterBeginJob() abuses getcwd() in a way that depends on undefined behavior, breaking with gcc 6.3.0. This patch fixes the undefined behavior and makes it more robust handling long paths and other errors that never happen.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dan131riley (Dan Riley) for master.

It involves the following packages:

CommonTools/UtilAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19425/console Started: 2017/04/26 20:55

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18485/19425/summary.html

Comparison Summary:

  • You potentially added 12 lines to the logs
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1783681
  • DQMHistoTests: Total failures: 2278
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1781230
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 28, 2017

+1

for #18485 8ff1714

  • the changes appear to resolve issues with long path names
  • jenkins tests pass

@davidlange6 davidlange6 merged commit 446cd60 into cms-sw:master Apr 29, 2017
@dan131riley dan131riley deleted the TFileService_getcwd branch October 9, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants