New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix getcwd() usage to avoid undefined behavior #18485
Conversation
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: CommonTools/UtilAlgos @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 for #18485 8ff1714
|
TFileService::afterBeginJob() abuses getcwd() in a way that depends on undefined behavior, breaking with gcc 6.3.0. This patch fixes the undefined behavior and makes it more robust handling long paths and other errors that never happen.