Work around: allow production of LHERunInfoProduct at begin Run

[Dr15Jones]

Other modules in the schedule require that LHERunInfoProduct be
available in the Run at begin run time even though the data product
is mergeable.
ExternalLHEProducer also puts the product in at both begin and end
run time which is not a behavior expected by the framework and
just happens to work.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

GeneratorInterface/LHEInterface

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19446/console Started: 2017/04/27 20:11

[Dr15Jones]

This fixes the failures in the IB, such as
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc530/CMSSW_9_1_X_2017-04-26-2300/pyRelValMatrixLogs/run/1360.0_TTbar012Jets_NLO_Mad_py8_Evt_13+TTbar012Jets_NLO_Mad_py8_Evt_13+DIGIUP15+RECOUP15+HARVESTUP15/step1_TTbar012Jets_NLO_Mad_py8_Evt_13+TTbar012Jets_NLO_Mad_py8_Evt_13+DIGIUP15+RECOUP15+HARVESTUP15.log

[I do not know why my original tests which ran the entire runTheMatrix.py missed these]

[cmsbuild]

+1
Tested at: fa2605b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18499/19446/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2c1aaa7
b07eeae
3d14897
5a546be
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18499/19446/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18499/19446/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18499/19446/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 3097 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1778712
• DQMHistoTests: Total failures: 30740
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 1747780
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[gpetruc]

Hi Chris,

Should this allow also to read the LHERunInfoProduct at any beginRun method in subsequent processes on the file?

I tried today on /store/mc/RunIISummer17MiniAOD/TT_TuneCUETP8M2T4_13TeV-powheg-pythia8/MINIAODSIM/92X_upgrade2017_realistic_v10_ext1-v1/110000/187F7EDA-0986-E711-ABB3-02163E014C21.root and if I do getByToken for it in the globalBeginRunSummary I do still get an exception claiming that the product can be accessed only in the endRun.

This is a big problem since AFAIK this is the product from which one can read the meaning of the LHE weights, and so it's needed before processing the events, not after.

@bendavid @arizzi

[Dr15Jones]

The object gets modified each time a new file is openned which contains the same run. Therefore the weights keep changing until the end Run transition happens.

[bendavid]

That may be true of the cross section information stored in the LHE init block, but it's not true of the header information strings that people mostly need to access.

[bendavid]

Uh, won't this pull request as is completely break the storage of cross section information in the LHE run product?

[gpetruc]

could the more stable header information be put in a product that is readable at begin run?
what are the requirements for a run product to be readable at begin run?