Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean unused HCAL DB packages #18502

Merged
merged 5 commits into from May 2, 2017
Merged

Conversation

kpedro88
Copy link
Contributor

I identified two packages of unused, unmaintained HCAL DB code: OnlineDB/HcalCondDB and CaloOnlineTools/HcalOnlineDb. I have removed these packages to reduce the incidental maintenance and dependency burden from their continued existence.

attn: @abdoulline, @bsunanda

@smuzaffar @davidlange6 should I remove these packages from cms-bot/categories.py?

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

CaloOnlineTools/HcalOnlineDb
CondTools/Hcal
OnlineDB/HcalCondDB

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19448/console Started: 2017/04/27 23:41

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18502/19448/summary.html

Comparison Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 3362 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1778644
  • DQMHistoTests: Total failures: 32538
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1745933
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@kpedro88
Copy link
Contributor Author

kpedro88 commented May 1, 2017

@ggovi please take a look

@ggovi
Copy link
Contributor

ggovi commented May 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants