Revert "Merge pull request #15458 from mdhildreth/HIPPreMix80X" #18528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @mandrenguyen for CMSSW_8_0_X. It involves the following packages: DataFormats/StdDictionaries @smuzaffar, @civanch, @Dr15Jones, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Seems it's the only solution at the moment. Can someone confirm it actually fixes the problem?
Cheers
David
On May 1, 2017, at 12:11 PM, mandrenguyen <notifications@github.com<mailto:notifications@github.com>> wrote:
This reverts commit ff83b47<ff83b47>, reversing
changes made to 0125196<0125196>.
@davidlange6<https://github.com/davidlange6> @mdhildreth<https://github.com/mdhildreth> : Is this your preferred (interim) solution ?
…________________________________
You can view, comment on, or merge this pull request online at:
#18528
Commit Summary
* Revert "Merge pull request #15458 from mdhildreth/HIPPreMix80X"
File Changes
* M DataFormats/StdDictionaries/src/classes_def_others.xml<https://github.com/cms-sw/cmssw/pull/18528/files#diff-0> (1)
* M DataFormats/StdDictionaries/src/classes_def_vector.xml<https://github.com/cms-sw/cmssw/pull/18528/files#diff-1> (2)
* M DataFormats/StdDictionaries/src/classes_others.h<https://github.com/cms-sw/cmssw/pull/18528/files#diff-2> (1)
* M DataFormats/StdDictionaries/src/classes_vector.h<https://github.com/cms-sw/cmssw/pull/18528/files#diff-3> (1)
* M DataFormats/WrappedStdDictionaries/src/classes.h<https://github.com/cms-sw/cmssw/pull/18528/files#diff-4> (4)
* M DataFormats/WrappedStdDictionaries/src/classes_def.xml<https://github.com/cms-sw/cmssw/pull/18528/files#diff-5> (1)
* M SimGeneral/Configuration/python/SimGeneral_EventContent_cff.py<https://github.com/cms-sw/cmssw/pull/18528/files#diff-6> (1)
* M SimGeneral/DataMixingModule/plugins/DataMixingSiStripMCDigiWorker.cc<https://github.com/cms-sw/cmssw/pull/18528/files#diff-7> (167)
* M SimGeneral/DataMixingModule/plugins/DataMixingSiStripMCDigiWorker.h<https://github.com/cms-sw/cmssw/pull/18528/files#diff-8> (14)
* M SimGeneral/DataMixingModule/python/mixOne_simraw_on_sim_cfi.py<https://github.com/cms-sw/cmssw/pull/18528/files#diff-9> (9)
* M SimGeneral/MixingModule/plugins/MixingModule.cc<https://github.com/cms-sw/cmssw/pull/18528/files#diff-10> (89)
* M SimGeneral/MixingModule/python/SiStripSimParameters_cfi.py<https://github.com/cms-sw/cmssw/pull/18528/files#diff-11> (5)
* M SimTracker/SiStripDigitizer/plugins/SiStripDigitizer.cc<https://github.com/cms-sw/cmssw/pull/18528/files#diff-12> (37)
* M SimTracker/SiStripDigitizer/plugins/SiStripDigitizer.h<https://github.com/cms-sw/cmssw/pull/18528/files#diff-13> (21)
* M SimTracker/SiStripDigitizer/plugins/SiStripDigitizerAlgorithm.cc<https://github.com/cms-sw/cmssw/pull/18528/files#diff-14> (148)
* M SimTracker/SiStripDigitizer/plugins/SiStripDigitizerAlgorithm.h<https://github.com/cms-sw/cmssw/pull/18528/files#diff-15> (18)
Patch Links:
* https://github.com/cms-sw/cmssw/pull/18528.patch
* https://github.com/cms-sw/cmssw/pull/18528.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18528>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywwT7zMYM5Al0f2cVgWH4hXBwCr-tks5r1a_VgaJpZM4NM9Ip>.
|
|
@davidlange6 I confirmed that the offlinePrimaryVertices are sensible again (i.e., have non-beamspot values) with this reversion in place. |
|
Comparison is ready Comparison Summary:
|
|
Ok thanks. I'll try to have a release put together tomorrow
Cheers,
David
On 1 May 2017, at 18:37, mandrenguyen <notifications@github.com<mailto:notifications@github.com>> wrote:
@davidlange6<https://github.com/davidlange6> I confirmed that the offlinePrimaryVertices are sensible again (i.e., have non-beamspot values) with this reversion in place.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18528 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw97B0Enq2Zj70Q7w1oB_Rr8js6aGks5r1govgaJpZM4NM9Ip>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ff83b47, reversing
changes made to 0125196.
@davidlange6 @mdhildreth : Is this your preferred (interim) solution ?