adding Phase1 timing client with tracking #18529
Conversation
|
A new Pull Request was created by @fioriNTU for master. It involves the following packages: DQM/Integration @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
|
||
| # Pixel Digi Monitoring | ||
| from DQM.SiPixelPhase1Digis.SiPixelPhase1Digis_cfi import * | ||
| SiPixelPhase1DigisAnalyzer.src = cms.InputTag("siPixelDigis") # adapt for real data |
There was a problem hiding this comment.
Hi @fioriNTU - this does not need to be here (as it does not change anything - if it did, then you would need to clone the module) - please remove it
There was a problem hiding this comment.
yes, thanks for noticing, I will fix
| #from DQM.SiPixelPhase1Summary.SiPixelPhase1Summary_cfi import * | ||
|
|
||
|
|
||
| siPixelPhase1OnlineDQM_source = cms.Sequence( |
There was a problem hiding this comment.
would be great if this implementation was shared with the offline cff... (its mostly a duplication)
There was a problem hiding this comment.
I would prefer to keep this completely independent by the Offline config. This piece is only used in the timing client, if someone mess it up will be transparent to the Offline
|
Pull request #18529 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
@davidlange6 you made me spot also a trivial error, I have set the geometry back to Phase 1 also, thanks. |
|
@davidlange this is not going to be integrated in 91X? |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -82,8 +82,8 @@ | |||
| # | |||
|
|
|||
| # To Configure Phase1 DQM for Phase0 data | |||
| SiPixelPhase1Geometry.upgradePhase = 0 | |||
| SiPixelPhase1Geometry.onlineblock = 5 | |||
| SiPixelPhase1Geometry.upgradePhase = 1 | |||
There was a problem hiding this comment.
Yuck...
lets remove this sort of flag in favor of geometry driven code..
|
+1 |
This PR adds an Online client with track reconstruction to perform Pixel timing in collisions
Also few minor things are modified: