Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a boost on particles in MCSingleParticle Filters #18532

Merged

Conversation

stahlleiton
Copy link
Contributor

This PR includes the option to perform a boost in the MCSingleParticleFilters in order to apply a generator-level cut on the momenta of single particles in the laboratory frame, instead of the center of mass frame, in the case of boosted MC production (for proton-lead). This PR follows the same strategy as #16425

@kurtejung , @mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2017

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

GeneratorInterface/GenFilters

@cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

@kurtejung
Copy link
Contributor

Hi @stahlleiton - I think this PR should be for 80X and not for 91X, correct? Maybe both if you want to have it for the next asymmetric collision run (2019-2020?)

@stahlleiton
Copy link
Contributor Author

Hi @kurtejung . This PR is mainly intended for 80X, so I will make a backport of it as soon as possible, but I thought it was better to submit it first to the master branch.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2017

Pull request #18532 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

@govoni
Copy link
Contributor

govoni commented May 2, 2017

I have a curiosity: do you check anywhere that beta is < 1?

@perrozzi
Copy link
Contributor

perrozzi commented May 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19490/console Started: 2017/05/02 10:07

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Comparison job queued.

@stahlleiton
Copy link
Contributor Author

Hi @govoni , I didn't include a check if beta is < 1.

@govoni
Copy link
Contributor

govoni commented May 2, 2017

Is it fine like that, or could it create any inconsistencies in the future, in case of a mistake in the input parameters?

@stahlleiton
Copy link
Contributor Author

Ok. I will add an if condition that returns an error message if beta is larger or equal 1.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2017

Pull request #18532 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Pull request #18532 was updated. @cmsbuild, @govoni, @perrozzi, @thuer, @davidlange6 can you please check and sign again.

@stahlleiton
Copy link
Contributor Author

@davidlange6 : Thanks for your review. I included the suggested changes. If you consider them fine, I will then proceed to propagate them to the other backport PRs.

@govoni
Copy link
Contributor

govoni commented May 4, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19581/console Started: 2017/05/04 22:43

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18532/19581/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1669 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 25499
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 1805370
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3725cb2 into cms-sw:master May 5, 2017
@stahlleiton stahlleiton deleted the BetaBoostForMCSingleParticleFilters branch February 20, 2018 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants