Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-alca79 Add monitoring HF dual readout Anode o/p for calibration #18565

Merged
merged 1 commit into from May 11, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 4, 2017

Also move all ROOT macros to a separate directory

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalCalibAlgos

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented May 4, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19566/console Started: 2017/05/04 13:40

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18565/19566/summary.html

Comparison Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 1702 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1835853
  • DQMHistoTests: Total failures: 27222
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1808451
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@bsunanda
Copy link
Contributor Author

bsunanda commented May 8, 2017

@arunhep @franzoni Can you approve this?

@arunhep
Copy link
Contributor

arunhep commented May 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2b8152a into cms-sw:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants