Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[91X] Fix configuration for DA_vect clusterizer in PV Validation tool (after #18330 merging) #18573

Merged
merged 1 commit into from May 8, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 4, 2017

backport of #18561

Title says it all. Solves issue reported at #18330 (comment)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2017

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_9_1_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 4, 2017

type bugfix

@arunhep
Copy link
Contributor

arunhep commented May 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19605/console Started: 2017/05/05 15:48

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18573/19605/summary.html

Comparison Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 3342 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 46441
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1784463
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@arunhep
Copy link
Contributor

arunhep commented May 5, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c832c2d into cms-sw:CMSSW_9_1_X May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants