Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for regression in the persistency of std::string payloads #18580

Merged
merged 2 commits into from May 12, 2017

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented May 5, 2017

Fix for std::string type matching. A recent compiler change has changed the output of the 'demangler' for the std::string class.
Regression test adapted for execution in IB environment. This test will now run correctly once the above fix will be in a main release

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

A new Pull Request was created by @ggovi for CMSSW_9_1_X.

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented May 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19586/console Started: 2017/05/05 09:50

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

-1

Tested at: 0d68899

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18580/19586/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Pull request #18580 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18580/19586/summary.html

Comparison Summary:

  • You potentially added 45 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3380 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 18491
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1812413
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented May 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19611/console Started: 2017/05/05 20:19

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

-1

Tested at: f6de5fe

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18580/19611/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testAlignmentOfflineValidation had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18580/19611/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1646 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 11726
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1819178
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented May 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19659/console Started: 2017/05/09 09:15

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@ggovi
Copy link
Contributor Author

ggovi commented May 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18580/19659/summary.html

Comparison Summary:

  • You potentially added 26 lines to the logs
  • Reco comparison results: 1678 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831084
  • DQMHistoTests: Total failures: 38338
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1792566
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e318360 into cms-sw:CMSSW_9_1_X May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants