New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for regression in the persistency of std::string payloads #18580
Fixes for regression in the persistency of std::string payloads #18580
Conversation
…ion in IB environment.
A new Pull Request was created by @ggovi for CMSSW_9_1_X. It involves the following packages: CondCore/CondDB @ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 0d68899 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testAlignmentOfflineValidation had ERRORS |
Comparison job queued. |
Pull request #18580 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again. |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
-1 Tested at: f6de5fe You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testAlignmentOfflineValidation had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
Comparison is ready Comparison Summary:
|
+1 |
Fix for std::string type matching. A recent compiler change has changed the output of the 'demangler' for the std::string class.
Regression test adapted for execution in IB environment. This test will now run correctly once the above fix will be in a main release