Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rhoCorr and energy-binned cuts (91X) #18585

Merged
merged 3 commits into from May 12, 2017
Merged

Add rhoCorr and energy-binned cuts (91X) #18585

merged 3 commits into from May 12, 2017

Conversation

afiqaize
Copy link
Contributor

@afiqaize afiqaize commented May 5, 2017

This is a clone of #18559 but for 91X milestone.

Let's hope I get it right this time.

@cmsbuild cmsbuild added this to the CMSSW_9_1_X milestone May 5, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

A new Pull Request was created by @afiqaize (Afiq Anuar) for CMSSW_9_1_X.

It involves the following packages:

HLTrigger/Configuration
HLTrigger/Egamma

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19594/console Started: 2017/05/05 12:54

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

+1
Tested at: e38d5d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18585/19594/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18585/19594/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3290 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831118
  • DQMHistoTests: Total failures: 32307
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1798631
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@Martin-Grunewald
Copy link
Contributor

@afiqaize
There are now merge conflicts, please fix this PR!

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

Pull request #18585 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19638/console Started: 2017/05/08 13:49

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

+1
Tested at: 8430954
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18585/19638/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8430954
c832c2d
5a480bb
9c49318
6492e02
b7321f8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18585/19638/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18585/19638/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Pull request #18585 was updated. @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19665/console Started: 2017/05/09 11:38

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

+1
Tested at: 20055d4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18585/19665/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18585/19665/summary.html

Comparison Summary:

  • You potentially added 54 lines to the logs
  • Reco comparison results: 3367 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831050
  • DQMHistoTests: Total failures: 48266
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1782604
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@Martin-Grunewald
Copy link
Contributor

@davidlange6
Please integrate this PR in 91X now that it works in 92X.

@Martin-Grunewald
Copy link
Contributor

@davidlange6
What is holding up integration of this PR?

@ggovi
Copy link
Contributor

ggovi commented May 11, 2017

+1

@ggovi
Copy link
Contributor

ggovi commented May 11, 2017

HTH, not sure why this one requires the db signature...

@Martin-Grunewald
Copy link
Contributor

...it doesn't -??

@Martin-Grunewald
Copy link
Contributor

@davidlange6
PING

@davidlange6
Copy link
Contributor

+1
fixing stuff takes priority over new stuff - and in any case, pinging the morning after I had to fix the PR for you is not likely to increase the rate at which your requests get integrated

@cmsbuild cmsbuild merged commit de37182 into cms-sw:CMSSW_9_1_X May 12, 2017
@afiqaize afiqaize deleted the egmFiltFor91X branch May 12, 2017 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@afiqaize @cmsbuild @Martin-Grunewald @perrotta @ggovi @davidlange6