Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L3 Muon Filter Fix (Master Branch) #18602

Merged
merged 4 commits into from May 8, 2017
Merged

Conversation

BenjaminRS
Copy link
Contributor

This fix first tidies up the code (and corrects the logic) in HLTMuonL3PreFilter and then propagates these modifications to the HLTMuonDimuonL3Filter and HLTMuonTrimuonL3Filter allowing them to work with the new L3 code: iterL3
It is the same as PR #18598 now in the master branch

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2017

A new Pull Request was created by @BenjaminRS (Benjamin Radburn-Smith) for master.

It involves the following packages:

HLTrigger/Muon

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @calderona, @HuguesBrun, @trocino this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19633/console Started: 2017/05/08 09:29

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18602/19633/summary.html

Comparison Summary:

  • You potentially added 3941 lines to the logs
  • Reco comparison results: 1618 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831152
  • DQMHistoTests: Total failures: 41377
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1789595
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants