Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the default cluster collections to PF #1862

Merged
merged 2 commits into from Dec 18, 2013
Merged

Updating the default cluster collections to PF #1862

merged 2 commits into from Dec 18, 2013

Conversation

yiiyama
Copy link
Contributor

@yiiyama yiiyama commented Dec 18, 2013

This pull request updates the ECAL DQM modules that run over the cluster collections to have the particleFlowClusters as the default source.
The source name is only changed for pp configurations. For HI and cosmics, the original files are kept in
DQMOffline/Ecal/python/ecal_dqm_source_offline_{cosmics|HI}_cff.py

The customizer provided by the Egamma group (RecoEgamma/Configuration/python/customizeOldEGReco.py, in #1834) has the function _customize_DQM, which is empty in the PR. The implementation of the exists but is not included in any PR yet.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @yiiyama (Yutaro Iiyama) for CMSSW_7_0_X.

Updating the default cluster collections to PF

It involves the following packages:

DQM/EcalBarrelMonitorTasks
DQM/EcalEndcapMonitorTasks
DQMOffline/Ecal

@nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@deguio
Copy link
Contributor

deguio commented Dec 18, 2013

+1

@cmsbuild
Copy link
Contributor

Pull request #1862 was updated. @nclopezo, @danduggan, @rovere, @cmsbuild, @deguio, @eliasron can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Dec 18, 2013

+1

@ktf
Copy link
Contributor

ktf commented Dec 18, 2013

@deguio gives his +1, but he has some identity problems at the moment. Once the tests will pass this will be integrated.

@deguio
Copy link
Contributor

deguio commented Dec 18, 2013

thanks @ktf

@deguio
Copy link
Contributor

deguio commented Dec 18, 2013

+1
hopefully I am back

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes (tests are also fine). @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 18, 2013
DQM updates -- Updating the default cluster collections to PF
@ktf ktf merged commit 01c51f0 into cms-sw:CMSSW_7_0_X Dec 18, 2013
@yiiyama yiiyama deleted the ecal_dqm_gedclusters branch February 15, 2014 22:13
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Update matplotlib to version 1.4.3. Add py2-six py2-pyparsing required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants