Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppi candidates for b tagging of Puppi jets in all eras #18666

Conversation

ferencek
Copy link
Contributor

This PR is a follow-up to #18317 and #18426

The PR switches the b tagging input for Puppi jets from PF candidates to Puppi candidates for all eras, not just Phase 2.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

1 similar comment
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19724/console Started: 2017/05/10 16:38

@slava77
Copy link
Contributor

slava77 commented May 10, 2017

@ferencek
please provide some notes to justify why this works now.
Did we get results from more recent studies?
Please provide a link to those for this PR description.
Thank you.

@ferencek
Copy link
Contributor Author

@slava77, for now there are no extra studies but this change will make such studies easier because everything needed will already be in MiniAOD without the need for re-running anything privately.

@slava77
Copy link
Contributor

slava77 commented May 10, 2017 via email

@ferencek
Copy link
Contributor Author

@slava77, indeed, this could have been done a while back. Sorry for the delay.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18666/19724/summary.html

Comparison Summary:

  • You potentially added 34 lines to the logs
  • Reco comparison results: 1671 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830372
  • DQMHistoTests: Total failures: 37750
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1792442
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ferencek ferencek changed the title Puppi candidates for b tagging of Puppi jets in all era Puppi candidates for b tagging of Puppi jets in all eras May 10, 2017
@slava77
Copy link
Contributor

slava77 commented May 11, 2017

+1

for #18666 6d68c61

  • changes are as described: b-tags computed in miniAOD for ak4 puppi jets to use puppi candidates instead of full pf by default (without special era modifications)
  • jenkins tests pass and comparisons show now differences (these btags are not monitored)

@davidlange6 davidlange6 merged commit 9b5c8c4 into cms-sw:master May 12, 2017
@ferencek ferencek deleted the PuppiForBTagging-PR_from-CMSSW_9_1_0_pre3 branch May 17, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants