New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabling profiling with intel Amplifier by ignoring signal 38 #18702
Conversation
A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master. It involves the following packages: FWCore/Utilities @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
sorry - just to understand what possible side effects this can have - signal 38 is somehow never used by other components? (leading to possible wrong behavior in normal operations) |
Normally we mask it, so I don't think anything should be able to use it to communicate to or through cmsRun. |
maybe I have this backwards - we normally mask the signal means that this PR proposes to increase the list of signals that the FWK allows? |
Yes, this now allows cmsRun to see the signal that the Intel tool needs to send to the application. |
+1 |
Intel Amplifier uses signal 38 to collect profiling data.
For this reason, this signal should be ignored by the framework.
@fwyzard @rovere @VinInn