Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling profiling with intel Amplifier by ignoring signal 38 #18702

Merged
merged 1 commit into from May 15, 2017

Conversation

felicepantaleo
Copy link
Contributor

Intel Amplifier uses signal 38 to collect profiling data.
For this reason, this signal should be ignored by the framework.

@fwyzard @rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @felicepantaleo (Felice Pantaleo) for master.

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ebrondol, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@VinInn
Copy link
Contributor

VinInn commented May 12, 2017

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19796/console Started: 2017/05/12 20:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18702/19796/summary.html

Comparison Summary:

  • You potentially added 163 lines to the logs
  • Reco comparison results: 1690 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1830696
  • DQMHistoTests: Total failures: 27303
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1803213
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

sorry - just to understand what possible side effects this can have - signal 38 is somehow never used by other components? (leading to possible wrong behavior in normal operations)

@fwyzard
Copy link
Contributor

fwyzard commented May 15, 2017

Normally we mask it, so I don't think anything should be able to use it to communicate to or through cmsRun.
I can't say about external tools.

@davidlange6
Copy link
Contributor

maybe I have this backwards - we normally mask the signal means that this PR proposes to increase the list of signals that the FWK allows?

@Dr15Jones
Copy link
Contributor

Yes, this now allows cmsRun to see the signal that the Intel tool needs to send to the application.

@davidlange6
Copy link
Contributor

+1
thanks

@cmsbuild cmsbuild merged commit 9711d54 into cms-sw:master May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants