Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix L1TGlobalPrescalesVetosESProducer (91x backport) #18713

Merged
merged 3 commits into from May 16, 2017
Merged

fix L1TGlobalPrescalesVetosESProducer (91x backport) #18713

merged 3 commits into from May 16, 2017

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 12, 2017

Fix a bug when less than 512 prescales are given in the XML file.
Before, the prescales for some of the triggers without an entry would not be initalised, and would be set to random values.

clean up

  • fill whole vectors instead of individual values
  • issue a LogError if a non-empty filename is not found
  • clang-tidy 3.8.0 modernize checks

@fwyzard
L1TGlobalPrescalesVetosESProducer: issue a LogError if a non-empty fi…
0c21e58 
…lename is not found
@fwyzard
L1TGlobalPrescalesVetosESProducer: fill whole vectors instead of indi…
2ed9edd 
…vidual values

This also fixes a bug where less than 512 prescales are given in the XML file.
Before, the prescales for some of the triggers without an entry would not be
initalised, and would be set to random values.
@fwyzard
cleaned up by clang-tidy 3.8.0 modernize checks
f7bb169 
Enabled checks:
    modernize-loop-convert
    modernize-make-unique
    modernize-pass-by-value
    modernize-redundant-void-arg
    modernize-replace-auto-ptr
    modernize-shrink-to-fit
    modernize-use-auto
    modernize-use-default
    modernize-use-nullptr
    modernize-use-override
@cmsbuild cmsbuild added this to the CMSSW_9_1_X milestone May 12, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_1_X.

It involves the following packages:

L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented May 12, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19790/console Started: 2017/05/12 15:44

@fwyzard
Copy link
Contributor Author

fwyzard commented May 12, 2017

backport of #18712

@fwyzard
Copy link
Contributor Author

fwyzard commented May 12, 2017

@rekovic can you sing this ASAP ?
this breaks all trigger studies using the current recipe to load prescales from an XML file

@cmsbuild
Copy link
Contributor

+1
Tested at: f7bb169
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18713/19790/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18713/19790/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1689 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1831118
  • DQMHistoTests: Total failures: 27317
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1803621
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@Martin-Grunewald
Copy link
Contributor

@rekovic @mulhearn
Please sign this PR.
Thanks!

@rekovic
Copy link
Contributor

rekovic commented May 15, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eb14b71 into cms-sw:CMSSW_9_1_X May 16, 2017
@fwyzard fwyzard deleted the fix_L1TGlobalPrescalesVetosESProducer branch July 11, 2017 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport comparison-available fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fwyzard @cmsbuild @Martin-Grunewald @rekovic @davidlange6