Keep gen-level nuclear info

[mandrenguyen]

This is a forward port of the 75X PR #12344, which somehow got lost in the shuffle.
#12344

This keeps all nuclear information (npart, ncoll, reaction plane) which is necessary when the HepMCProduct is dropped.
This info takes up very little extra space and is contained in:
edm::GenHIEvent "heavyIon" "" "HLT"

This is produced and stored when the following flags are set, e.g., in wf 145:
DIGI:pdigi_hi
--pileup HiMixNoPU

[cmsbuild]

A new Pull Request was created by @mandrenguyen for master.

It involves the following packages:

Configuration/Applications
Configuration/PyReleaseValidation
Configuration/StandardSequences
GeneratorInterface/HiGenCommon
SimGeneral/Configuration
SimGeneral/MixingModule

@thuer, @civanch, @kkousour, @perrozzi, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @govoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mkirsano, @makortel, @felicepantaleo, @cbaus, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @agrohsje, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

(75X! There's a blast from the past...)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19800/console Started: 2017/05/12 23:58

[cmsbuild]

+1
Tested at: fff07e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18721/19800/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18721/19800/summary.html

Comparison Summary:

• You potentially added 177 lines to the logs
• Reco comparison results: 3360 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1830696
• DQMHistoTests: Total failures: 62679
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1767837
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[kpedro88]

+1

[fabozzi]

+1

[perrozzi]

+1

[civanch]

+1

[kpedro88]

I noticed for some reason this PR causes a bunch of messages like this to be printed in the log for 25202.0 step3:

%MSG-w BasicTrajectoryState:  TrackRefitter:refittedForPixelDQM  13-May-2017 01:14:53 CEST Run: 1 Event: 5
curv error not pos-def
[  4.50264e+08-2.74183e+08     -719598 1.78261e+06-1.30321e+06
  -2.74183e+08 1.66961e+08      438191-1.08546e+06      793343
       -719598      438191     1150.03    -2842.11     2053.42
   1.78261e+06-1.08546e+06    -2842.11     7051.35    -4382.02
  -1.30321e+06      793343     2053.42    -4382.02    -3010.24 ]
pos/mom/mf  (-27.4582,-22.8356,-28.562)   (-0.154575,-0.385741,-0.375501)   (0.00180473,0.00150091,3.81049) 

Not sure if this is spurious or not, but maybe it should be checked in a larger sample?

[mandrenguyen]

@kpedro88 Somewhat hard to imagine that this could be responsible for the change you're observing. Only the wfs that use pdigi_hi should be affected. All other wfs should be bit-wise identical.

[davidlange6]

Hi @mandrenguyen - it looks like this also causes problems in workflows 300,301,302 - can you fix in the next hours? [I think you've missed a migration that happened since 75x]

Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: CrossingFrameedm::HepMCProduct
Looking for module label: mix
Looking for productInstanceName: generatorSmeared

Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 17-May-2017 13:16:38 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing Event run: 1 lumi: 1 event: 3 stream: 1
[1] Running path 'digitisation_step'
[2] Calling method for module GenHIEventProducer/'heavyIon'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: CrossingFrameedm::HepMCProduct
Looking for module label: mix
Looking for productInstanceName: generatorSmeared

[mandrenguyen]

@davidlange6 Thanks for spotting that. Looking now.