Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DQMServices/Core: Change DQMEDHarvester to an edm::one::EDProducer and add alias to EDProducer from DQMEDHarvester #18751

Merged
merged 4 commits into from May 27, 2017
Merged

DQMServices/Core: Change DQMEDHarvester to an edm::one::EDProducer and add alias to EDProducer from DQMEDHarvester #18751

merged 4 commits into from May 27, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented May 15, 2017

This changes DQMEDHarvester to a modified edm:1️⃣:producer. The config files need changing from EDAnalyzer to EDProducer in cases where a class inherits from DQMEDHarvester. I believe I have made all of the changes needed but this needs further testting

This also changes all config files for classes that directly or indirectly
inherit from DQMEDHarvester. The config for these classes was changed
from cms.EDAnalyzer to cms.EDProducer.

Add DQMEDProducer as an alias for EDProducer.
Change the config files for classes which inherit from DQMEDHarvester
to refer to DQMEDProducer instead on cms.EDProducer.

@gartung
Change DQMEDHarvester from an edm::one::EDAnalyzer to an edm::one::ED…
cac4f8d 
…Producer.

This also changes all config files for classes that directly or indirectly
inherit from DQMEDHarvester. The config for these classes must be changed
from cms.EDAnalyzer to cms.EDProducer.
@gartung
Add DQMEDHarvester as an alias for EDProducer.
bf7d507 
Change the config files for classes which inherit from DQMEDHarvester
to refer to DQMEDHarvester instead on cms.EDProducer.
@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone May 15, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm
CalibTracker/SiStripChannelGain
Calibration/EcalCalibAlgos
DQM/CSCMonitorModule
DQM/CTPPS
DQM/DTMonitorClient
DQM/EcalCommon
DQM/EcalMonitorClient
DQM/EcalMonitorDbModule
DQM/EcalPreshowerMonitorClient
DQM/HcalTasks
DQM/Integration
DQM/L1TMonitorClient
DQM/RPCMonitorClient
DQM/SiPixelCommon
DQM/SiPixelMonitorClient
DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Digis
DQM/SiPixelPhase1RawData
DQM/SiPixelPhase1RecHits
DQM/SiPixelPhase1Summary
DQM/SiPixelPhase1TrackClusters
DQM/SiPixelPhase1TrackEfficiency
DQM/SiPixelPhase1TrackResiduals
DQM/TrackingMonitor
DQM/TrackingMonitorClient
DQMOffline/Alignment
DQMOffline/CalibCalo
DQMOffline/EGamma
DQMOffline/Ecal
DQMOffline/Hcal
DQMOffline/JetMET
DQMOffline/L1Trigger
DQMOffline/Muon
DQMOffline/PFTau
DQMOffline/RecoB
DQMOffline/Trigger
DQMServices/Components
DQMServices/Core
DQMServices/Examples
FastSimulation/Calorimetry
GeneratorInterface/RivetInterface
HLTriggerOffline/B2G
HLTriggerOffline/Btag
HLTriggerOffline/Common
HLTriggerOffline/Egamma
HLTriggerOffline/Exotica
HLTriggerOffline/HeavyFlavor
HLTriggerOffline/Higgs
HLTriggerOffline/JetMET
HLTriggerOffline/Muon
HLTriggerOffline/SMP
HLTriggerOffline/SUSYBSM
HLTriggerOffline/Top
SLHCUpgradeSimulations/Geometry
Validation/CaloTowers
Validation/EventGenerator
Validation/HGCalValidation
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits
Validation/L1T
Validation/MuonGEMDigis
Validation/MuonGEMHits
Validation/MuonGEMRecHits
Validation/MuonIsolation
Validation/MuonME0Validation
Validation/RPCRecHits
Validation/RecoB
Validation/RecoEgamma
Validation/RecoJets
Validation/RecoMET
Validation/RecoMuon
Validation/RecoTrack
Validation/RecoVertex

@ghellwig, @civanch, @Dr15Jones, @lveldere, @arunhep, @perrozzi, @ianna, @kpedro88, @dmitrijus, @cmsbuild, @rekovic, @franzoni, @thuer, @cerminar, @mdhildreth, @mmusich, @vanbesien, @govoni, @mulhearn, @ssekmen, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @felicepantaleo, @abbiendi, @rappoccio, @kpedro88, @argiro, @Martin-Grunewald, @bsunanda, @pfs, @thomreis, @tlampen, @ahinzmann, @lgray, @threus, @mmusich, @venturia, @acimmino, @mmarionncern, @kreczko, @hdelanno, @calderona, @makortel, @acaudron, @jhgoh, @imarches, @jdolen, @jlagram, @HuguesBrun, @agrohsje, @ferencek, @OlivierBondu, @trocino, @rociovilar, @vandreev11, @barvic, @ptcox, @GiacomoSguazzoni, @tocheng, @VinInn, @cseez, @bellan, @nhanvtran, @gkasieczka, @rovere, @deguio, @schoef, @mschrode, @idebruyn, @ebrondol, @sethzenz, @mtosi, @dgulhan, @mkirsano, @batinkov, @battibass, @gbenelli, @JyothsnaKomaragiri, @mverzett, @wmtford, @matt-komm, @mariadalfonso, @pvmulder, @fioriNTU this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented May 15, 2017

@Dr15Jones I tried running runTheMatrix.py with the latest master but there is an error unrelated to the changes I made. Please test this.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

This was referenced May 15, 2017
Closed
Closed
@Dr15Jones
Copy link
Contributor

Either this pull request or #18717 will be used, not both.

@gartung
Copy link
Member Author

gartung commented May 15, 2017

@Dr15Jones please abort test and restart. I found a few typos.

@cmsbuild
Copy link
Contributor

Pull request #18751 was updated. @ghellwig, @civanch, @Dr15Jones, @lveldere, @arunhep, @perrozzi, @ianna, @kpedro88, @dmitrijus, @cmsbuild, @rekovic, @franzoni, @thuer, @cerminar, @mdhildreth, @mmusich, @vanbesien, @govoni, @mulhearn, @ssekmen, @davidlange6 can you please check and sign again.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19996/console Started: 2017/05/19 17:35

@cmsbuild
Copy link
Contributor

+1
Tested at: d0f77e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18751/19996/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor

ianna commented May 19, 2017

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18751/19996/summary.html

Comparison Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 1768 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833901
  • DQMHistoTests: Total failures: 23855
  • DQMHistoTests: Total nulls: 35
  • DQMHistoTests: Total successes: 1809831
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@dmitrijus
Copy link
Contributor

+1

@Dr15Jones
Copy link
Contributor

@lveldere @ssekmen @mdhildreth @civanch @govoni @perrozzi @thuer @mulhearn @rekovic please sign

@Dr15Jones
Copy link
Contributor

ping

@davidlange6 davidlange6 merged commit 95d1397 into cms-sw:master May 27, 2017
@gartung gartung deleted the DQMEDHarvester_EDProducer3 branch May 30, 2017 15:28
This was referenced May 30, 2017
Closed
Closed
@gomber gomber mentioned this pull request May 31, 2017
Merged
@aboletti aboletti mentioned this pull request Jun 1, 2017
Closed
@DryRun DryRun mentioned this pull request Jun 6, 2017
Merged
@Dr15Jones Dr15Jones mentioned this pull request Jun 15, 2017
Merged
@schneiml schneiml mentioned this pull request Jan 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrijus dmitrijus dmitrijus left review comments

@Dr15Jones Dr15Jones Dr15Jones left review comments

@fwyzard fwyzard fwyzard left review comments

@ghellwig ghellwig ghellwig approved these changes

Assignees
No one assigned
Labels
alca-approved comparison-available dqm-approved fastsim-pending generators-pending geometry-approved l1-pending orp-pending pending-signatures tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@gartung @cmsbuild @Dr15Jones @ianna @rekovic @ghellwig @fwyzard @kpedro88 @dmitrijus @davidlange6