Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dedx harmonic2 for pixel hits #18771

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 16, 2017

Lowering of pt from 15 GeV to 10 GeV increases signal yields by 10% for short (pixel-only) heavy high pt tracks.

Addition of the pixel-only harmonic2 enables calibration from AOD (it has to be done on low pt tracks; hence full addition)

the cost to AOD is under 1% (3kB/evt from the pixel-only harmonic2) based on checks in ttbar and Run2016H JetHT data.

this is only useful, if it can be added to the legacy rereco.

I have updated this PR to be more safe for the legacy reprocessing to simply add a new product.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X.

It involves the following packages:

RecoTracker/DeDx

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented May 16, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor Author

slava77 commented May 16, 2017

backport of #18773

@cmsbuild
Copy link
Contributor

Pull request #18771 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

@slava77 slava77 force-pushed the CMSSW_8_0_28/sign910/dedxHitInfoLowerPt branch from f55df95 to f8ea52e Compare May 16, 2017 16:19
@cmsbuild
Copy link
Contributor

Pull request #18771 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor Author

slava77 commented May 16, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19883/console Started: 2017/05/16 21:03

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18771/19883/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 16
  • DQMHistoTests: Total histograms compared: 1164335
  • DQMHistoTests: Total failures: 1094
  • DQMHistoTests: Total nulls: 59
  • DQMHistoTests: Total successes: 1163064
  • DQMHistoTests: Total skipped: 118
  • DQMHistoTests: Total Missing objects: 0
  • Checked 63 log files, 14 edm output root files, 16 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #18771 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

@slava77 slava77 changed the title lower pt cut on dedxhitinfo to 10 GeV and add dedx harmonic2 for pixel hits add dedx harmonic2 for pixel hits May 17, 2017
@slava77
Copy link
Contributor Author

slava77 commented May 17, 2017

I have updated this PR to be more safe for the legacy reprocessing to simply add a new product.
This is in case it is decided to still apply this to a fraction of PDs.

@slava77
Copy link
Contributor Author

slava77 commented May 17, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19927/console Started: 2017/05/17 14:52

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18771/19927/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 16
  • DQMHistoTests: Total histograms compared: 1164335
  • DQMHistoTests: Total failures: 1071
  • DQMHistoTests: Total nulls: 59
  • DQMHistoTests: Total successes: 1163087
  • DQMHistoTests: Total skipped: 118
  • DQMHistoTests: Total Missing objects: 0
  • Checked 63 log files, 14 edm output root files, 16 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented May 17, 2017

+1

for #18771 7fbca7e

  • adds a new product ecoDeDxDataedmValueMap_dedxPixelHarmonic2__ to AOD.
  • jenkins tests pass and the summary looks as expected:
    • No significant changes to the logs found
    • ROOTFileChecks: Some differences in event products or their sizes found
    • Reco comparison results: 0 differences found in the comparisons

This PR is valid only if existing legacy rereco pilots are to be redone for other reasons.
To be closed once actual production is clearly in progress.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@slava77
Copy link
Contributor Author

slava77 commented May 29, 2017

the full 80X LR campaign has started.
So, I'm closing this.

@slava77 slava77 closed this May 29, 2017
@slava77
Copy link
Contributor Author

slava77 commented Jul 10, 2017

Apparently this is a valid request again

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ae295f5 into cms-sw:CMSSW_8_0_X Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants