New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dedx harmonic2 for pixel hits #18771
add dedx harmonic2 for pixel hits #18771
Conversation
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_8_0_X. It involves the following packages: RecoTracker/DeDx @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
backport of #18773 |
Pull request #18771 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
f55df95
to
f8ea52e
Compare
Pull request #18771 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Pull request #18771 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
I have updated this PR to be more safe for the legacy reprocessing to simply add a new product. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
This PR is valid only if existing legacy rereco pilots are to be redone for other reasons. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_2_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
the full 80X LR campaign has started. |
Apparently this is a valid request again |
merge |
Lowering of pt from 15 GeV to 10 GeV increases signal yields by 10% for short (pixel-only) heavy high pt tracks.Addition of the pixel-only harmonic2 enables calibration from AOD (it has to be done on low pt tracks; hence full addition)
the cost to AOD is under 1% (3kB/evt from the pixel-only harmonic2) based on checks in ttbar and Run2016H JetHT data.
this is only useful, if it can be added to the legacy rereco.
I have updated this PR to be more safe for the legacy reprocessing to simply add a new product.