Fix clashes between translator function in PythonModule.h/.cc #18786
Conversation
We have two global TU-local 'translator' functions in CMSSW: One is in PythonModule.cc and one is in PythonModule.h. While having TU-local functions in a header is already not recommended, having them defined twice with the same name like this is causing undefined behavior that breaks the linker (and also the rest of clang in the future once someone includes the wrong file). This patch is making the name of the header function unique to prevent future compiler errors.
|
Part of the work to solve the issue #15248 |
|
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: FWCore/PythonParameterSet @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Comparison is ready Comparison Summary:
|
|
+1 |
We have two global TU-local 'translator' functions in CMSSW:
One is in PythonModule.cc and one is in PythonModule.h.
While having TU-local functions in a header is already not recommended,
having them defined twice with the same name like this is causing
undefined behavior that breaks the linker (and also the rest
of clang in the future once someone includes the wrong file).
This patch is making the name of the header function unique to prevent
future compiler errors.