Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include to LocalErrorBaseExtended.h #18795

Merged

Conversation

Teemperor
Copy link
Contributor

We use InvalidError in the constructor, so we also
need to include the TrivialError.h header to get the
definition of this class.

We use InvalidError in the constructor, so we also
need to include the TrivialError.h header to get the
definition of this class.
@Teemperor
Copy link
Contributor Author

Part of the work to solve the issue #15248

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

DataFormats/GeometrySurface

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented May 17, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19917/console Started: 2017/05/17 13:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18795/19917/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3368 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833867
  • DQMHistoTests: Total failures: 49247
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1784440
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@civanch
Copy link
Contributor

civanch commented May 18, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fe70af8 into cms-sw:master May 18, 2017
@Teemperor Teemperor deleted the MissingIncludeLocalErrorBaseExtended.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the MissingIncludeLocalErrorBaseExtended.h branch December 19, 2017 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants