Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PopCon BTransition module #18826

Merged
merged 1 commit into from May 19, 2017

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented May 18, 2017

This fix allows to share the session with the base PopCon, to avoid to hit the lock in the usage with sqlite file
The code changed is only used in the O2O processes.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondTools/RunInfo

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented May 18, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19957/console Started: 2017/05/18 09:48

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18826/19957/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3364 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833935
  • DQMHistoTests: Total failures: 34723
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1799032
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented May 18, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c1535f7 into cms-sw:master May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants