Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing rootcling warning about missing dependencies #18851

Merged
merged 2 commits into from May 23, 2017

Conversation

mrodozov
Copy link
Contributor

Fixes regarding issue #14473

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

DataFormats/BeamSpot
DataFormats/CTPPSReco
DataFormats/CaloRecHit
DataFormats/CaloTowers
DataFormats/EgammaCandidates
DataFormats/HcalIsolatedTrack
DataFormats/METReco
DataFormats/ParticleFlowCandidate
DataFormats/ParticleFlowReco
DataFormats/PatCandidates
DataFormats/Phase2TrackerCluster
DataFormats/RecoCandidate
DataFormats/SiStripCluster
DataFormats/TrackCandidate
DataFormats/TrackReco
DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit
DataFormats/TrajectorySeed

@perrotta, @kpedro88, @monttj, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @threus, @ebrondol, @mmarionncern, @makortel, @lgray, @jdolen, @OlivierBondu, @Sam-Harper, @rafaellopesdesa, @VinInn, @nhanvtran, @gkasieczka, @schoef, @mmusich, @ahinzmann, @cbernet, @gpetruc, @mariadalfonso, @bachtis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19988/console Started: 2017/05/19 13:08

@cmsbuild
Copy link
Contributor

-1

Tested at: 297c135

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
297c135
be31bd6
d9f3116
c1535f7
754d030
d9dd93d
9a29c64
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18851/19988/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18851/19988/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18851/19988/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testJetMETCorrectionsType1MET had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
297c135
be31bd6
d9f3116
c1535f7
754d030
d9dd93d
9a29c64
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18851/19988/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18851/19988/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18851/19988/summary.html

Comparison Summary:

  • You potentially added 48 lines to the logs
  • Reco comparison results: 3374 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833867
  • DQMHistoTests: Total failures: 49166
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1784521
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@perrotta
Copy link
Contributor

please test

The error on testJetMETCorrectionsType1MET [1] does not seem correlated.
Let try restart tests in a cleaner area (with possibly no additional commits attached)

[1]
----- Begin Fatal Exception 19-May-2017 15:57:39 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
[0] Processing the python configuration file named /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-18-2300/src/JetMETCorrections/Type1MET/test/corrMET_pfMet_cfg.py
Exception Message:
python encountered the error: <type 'exceptions.NameError'>
global name 'extract_value' is not defined
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20023/console Started: 2017/05/22 15:54

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18851/20023/summary.html

Comparison Summary:

  • You potentially added 69 lines to the logs
  • Reco comparison results: 3346 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1832922
  • DQMHistoTests: Total failures: 48707
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1784035
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@perrotta
Copy link
Contributor

+1
Technical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants