Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporarily disable setNoiseFlagsQIE11 for AlCa [920patch] #18855

Merged
merged 1 commit into from May 19, 2017

Conversation

kpedro88
Copy link
Contributor

Backport of #18853

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_2_0_patchX.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @ghellwig, @franzoni, @arunhep, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.
Note that this branch is designed for requested bug fixes specific to the CMSSW_9_2_0 release.
If you wish to make a pull request for the CMSSW_9_2_X release cycle, please use the CMSSW_9_2_X branch instead

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

ah - thanks - I hadn't noticed that the module name had changed to one of the alca producers that @bsunanda had cloned. Now.. the longer term question is if this era statement should be there at all. Presumably the clone picks up the era change from the original module definition and thus code the duplication is not needed (but this is a statement I did not check)

@davidlange6
Copy link
Contributor

will merge in parallel with tests to build a release while people are around

@davidlange6 davidlange6 merged commit 17566a3 into cms-sw:CMSSW_9_2_0_patchX May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants