Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing missing piece of das_client #18858

Merged
merged 1 commit into from May 20, 2017
Merged

Conversation

mrodozov
Copy link
Contributor

two definitions (of functions) were missing but used, added now

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

Utilities/General

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19992/console Started: 2017/05/19 16:32

@smuzaffar
Copy link
Contributor

this fixes the unit test failing in the IBs due to missing das client pieces in #18634

@smuzaffar
Copy link
Contributor

+1
@davidlange6 , we need to merge this so that other PRs where unit test testJetMETCorrectionsType1MET fails can be avoided

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18858/19992/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 95 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833901
  • DQMHistoTests: Total failures: 33249
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1800472
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@smuzaffar smuzaffar merged commit 4f34c7d into cms-sw:master May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants