Phase2-hgx83 Bug fixes to two codes

[bsunanda]

Utilization of the right RecHit collection and finding the right collection for the given DetID

[bsunanda]

@cmsbuild Please test

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Validation/HGCalValidation

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @kpedro88, @lgray, @cseez, @pfs this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19998/console Started: 2017/05/19 20:03

[cmsbuild]

+1
Tested at: 371f842
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18864/19998/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
be31bd6
d9f3116
c1535f7
754d030
d9dd93d
9a29c64
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18864/19998/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18864/19998/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18864/19998/summary.html

Comparison Summary:

• You potentially added 157 lines to the logs
• Reco comparison results: 1708 differences found in the comparisons
• DQMHistoTests: Total files compared: 24
• DQMHistoTests: Total histograms compared: 1833901
• DQMHistoTests: Total failures: 41676
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 1792044
• DQMHistoTests: Total skipped: 180
• DQMHistoTests: Total Missing objects: 0
• Checked 98 log files, 14 edm output root files, 24 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[davidlange6]

+1