New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved functions from anonymous namespace in CondCore/CondDB #18867
Conversation
gcc63 warned about unused template specialization in an anonymous namespace that was being included in multiple .cc files. Using anonymous namespaces in headers are not recommended.
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CondCore/CondDB @ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
ping |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
gcc63 warned about unused template specialization in an anonymous
namespace that was being included in multiple .cc files. Using
anonymous namespaces in headers are not recommended.