New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing includes to BoundaryInformation.h #18885
Add missing includes to BoundaryInformation.h #18885
Conversation
We need to include vector because we have multiple member variables of the type std::vector in this header. The include to EcalRecHit.h is necessary because of the recHits member variable.
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: DataFormats/METReco @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Part of the work going on regarding issue #15248 |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
We need to include vector because we have multiple member variables
of the type std::vector in this header.
The include to EcalRecHit.h is necessary because of the recHits
member variable.