Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added edmScanValgrind.py to discard false positives #18889

Merged
merged 1 commit into from May 23, 2017

Conversation

Dr15Jones
Copy link
Contributor

The script edmScanValgrind.py will scan through a valgrind long and
discard known false positives for cmsRun.

The script edmScanValgrind.py will scan through a valgrind long and
discard known false positives for cmsRun.
@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Utilities/ReleaseScripts

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 22, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20031/console Started: 2017/05/22 18:33

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@Dr15Jones
Copy link
Contributor Author

I put this little helper script in the data directory since that is where the valgrind suppression file lives. This basically is a supplement to that file.

@cmsbuild
Copy link
Contributor

-1

Tested at: a3918a6

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
894bc95
6aafd9f
8663bcd
3303eb4
5322da7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18889/20031/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18889/20031/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18889/20031/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
894bc95
6aafd9f
8663bcd
3303eb4
5322da7
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18889/20031/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18889/20031/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Dr15Jones
Copy link
Contributor Author

The unit test failure has nothing to do with this pull request.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18889/20031/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1773 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1832956
  • DQMHistoTests: Total failures: 9425
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1823351
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@davidlange6 davidlange6 merged commit a0b1a4d into cms-sw:master May 23, 2017
@Dr15Jones Dr15Jones deleted the addEdmScanValgrind branch May 23, 2017 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants