Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed class ELdestControl #18931

Merged
merged 1 commit into from May 27, 2017
Merged

Conversation

Dr15Jones
Copy link
Contributor

THe ELdestControl was just a wrapper around an ELdestination to attempt
to keep people from deleting it.

THe ELdestControl was just a wrapper around an ELdestination to attempt
to keep people from deleting it.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/MessageService

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20089/console Started: 2017/05/25 15:44
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20094/console Started: 2017/05/25 16:40

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18931/20094/summary.html

Comparison Summary:

  • You potentially added 29 lines to the logs
  • Reco comparison results: 3410 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1832990
  • DQMHistoTests: Total failures: 33114
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1799696
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@Dr15Jones
Copy link
Contributor Author

ping
I have some other cleanups to the same package that build on this.

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bbb4fb1 into cms-sw:master May 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants