New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CalibCalorimetry + CaloOnlineTools : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18934
CalibCalorimetry + CaloOnlineTools : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18934
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: CalibCalorimetry/HcalPlugins @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@@ -47,7 +47,7 @@ class HcalTextCalibrations : public edm::ESProducer, | |||
{ | |||
public: | |||
HcalTextCalibrations (const edm::ParameterSet& ); | |||
~HcalTextCalibrations (); | |||
virtual ~HcalTextCalibrations () {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this was already declared before, it means there must already exist an implementation of the destructor. Therefore the chang needed is virtual ~HcalTextCalibrations();
…rtual destructor [-Wnon-virtual-dtor]
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Fixes warnings like these by adding virtual destructor with default constructor.
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/CaloOnlineTools/HcalOnlineDb/interface/PluginManager.hh:33:9: warning: 'class hcal::AbstractPluginFactory' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/CalibCalorimetry/HcalPlugins/src/HcalTextCalibrations.h:55:9: warning: 'class HcalTextCalibrations::CheckGetObject' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/CalibCalorimetry/HcalPlugins/src/HcalTextCalibrations.h:67:9: warning: base class 'class HcalTextCalibrations::CheckGetObject' has accessible non-virtual destructor [-Wnon-virtual-dtor]