Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalibCalorimetry + CaloOnlineTools : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18934

Merged
merged 1 commit into from May 30, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented May 25, 2017

Fixes warnings like these by adding virtual destructor with default constructor.

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/CaloOnlineTools/HcalOnlineDb/interface/PluginManager.hh:33:9: warning: 'class hcal::AbstractPluginFactory' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/CalibCalorimetry/HcalPlugins/src/HcalTextCalibrations.h:55:9: warning: 'class HcalTextCalibrations::CheckGetObject' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/CalibCalorimetry/HcalPlugins/src/HcalTextCalibrations.h:67:9: warning: base class 'class HcalTextCalibrations::CheckGetObject' has accessible non-virtual destructor [-Wnon-virtual-dtor]

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

CalibCalorimetry/HcalPlugins
CaloOnlineTools/HcalOnlineDb

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented May 25, 2017

@Dr15Jones

@@ -47,7 +47,7 @@ class HcalTextCalibrations : public edm::ESProducer,
{
public:
HcalTextCalibrations (const edm::ParameterSet& );
~HcalTextCalibrations ();
virtual ~HcalTextCalibrations () {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was already declared before, it means there must already exist an implementation of the destructor. Therefore the chang needed is virtual ~HcalTextCalibrations();

@cmsbuild
Copy link
Contributor

Pull request #18934 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @davidlange6 can you please check and sign again.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20111/console Started: 2017/05/25 18:10

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18934/20111/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3400 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833592
  • DQMHistoTests: Total failures: 34319
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1799093
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@arunhep
Copy link
Contributor

arunhep commented May 29, 2017

+1
no change observed in comparison plots as expected.
purely technical changes.

@davidlange6 davidlange6 merged commit 9aa21b5 into cms-sw:master May 30, 2017
@gartung gartung deleted the Calo-gcc700-dtor-warning-fix branch May 30, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants