New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhysicsTools : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18942
PhysicsTools : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #18942
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: PhysicsTools/JetMCAlgos @perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: ce4ea61 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/src/Pythia8PartonSelector.cc >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/src/Herwig6PartonSelector.cc Selected class -> ExclusionBandPlot for ROOT: ExclusionBandPlot Selected class -> LEPBandPlot for ROOT: LEPBandPlot >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/test/matchGenHFHadrons.cc /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/src/BasePartonSelector.cc:7:1: error: definition of explicitly-defaulted 'BasePartonSelector::~BasePartonSelector()' BasePartonSelector::~BasePartonSelector() ^ In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/src/BasePartonSelector.cc:1:0: /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/interface/BasePartonSelector.h:17:13: error: 'virtual BasePartonSelector::~BasePartonSelector()' explicitly defaulted here virtual ~BasePartonSelector() = default;
I found a compilation error while trying to compile with clang: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/plugins/TauGenJetDecayModeSelector.cc Selected class -> ExclusionBandPlot for ROOT: ExclusionBandPlot Selected class -> LEPBandPlot for ROOT: LEPBandPlot >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/plugins/TauGenJetProducer.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/plugins/ttHFGenFilter.cc /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/src/BasePartonSelector.cc:7:21: error: definition of explicitly defaulted destructor BasePartonSelector::~BasePartonSelector() ^ 1 error generated. >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/plugins/GenHFHadronMatcher.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-05-25-1100/src/PhysicsTools/JetMCAlgos/plugins/HadronAndPartonSelector.cc |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
-1 |
@@ -14,7 +14,7 @@ class BasePartonSelector | |||
{ | |||
public: | |||
BasePartonSelector(); | |||
~BasePartonSelector(); | |||
virtual ~BasePartonSelector() {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for this problem is to do virtual ~BasePartonSelector()
. The definition of the function already exists somewhere.
…rtual destructor [-Wnon-virtual-dtor]
please test |
The tests are being triggered in jenkins. |
please test |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
Fixes warnings like these by adding virtual destructor with default constructor.
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/PhysicsTools/RooStatsCms/interface/BinomialInterval.h:18:7: warning: 'class BinomialInterval' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]
/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/8fa3f79dab694f86b12f10b4e4cceb97/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-21-2300/src/PhysicsTools/RooStatsCms/interface/BinomialNoncentralInterval.h:31:7: warning: base class 'class BinomialInterval' has accessible non-virtual destructor [-Wnon-virtual-dtor]