add offline DQM for NoBPTX EXO triggers #18950

jalimena · 2017-05-25T18:22:07Z

Creates offline DQM for the NoBPTX triggers for the 2017 pp collisions menu, which are owned by Exotica.

jalimena · 2017-05-25T18:22:25Z

TSG approval presentation: https://indico.cern.ch/event/637425/contributions/2586884/attachments/1457334/2249380/NoBPTXTriggersFor2017_10May2017.pdf
And corresponding JIRA ticket: https://its.cern.ch/jira/browse/CMSHLT-1252

cmsbuild · 2017-05-25T18:22:49Z

A new Pull Request was created by @jalimena (Juliette Alimena) for master.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-05-26T07:41:47Z

DQMOffline/Trigger/plugins/NoBPTXMonitor.cc

+  jetENoBPTX_variableBinning_.denominator = nullptr;
+  jetEVsLS_.numerator   = nullptr;
+  jetEVsLS_.denominator = nullptr;
+


why don't you add eta and phi ?

in addition, shouldn't the jet depend on HEP17 ?
I think you should add a 2D map, at least

Hi @mtosi,
I have now added eta and phi plots for the jets, as you can see from my latest commit. We do not use HEP17 in the analysis, so no, I don't think so.

mtosi · 2017-05-26T07:42:01Z

DQMOffline/Trigger/plugins/NoBPTXMonitor.cc

+  muonPtNoBPTX_variableBinning_.denominator = nullptr;
+  muonPtVsLS_.numerator   = nullptr;
+  muonPtVsLS_.denominator = nullptr;
+


as above, eta and phi ...

are you interested in d_xy or d_z ?

what about BX ?

I have also added eta and phi plots for the muons.

The analysis does not actually use d_xy or d_z, so no, I don't think it makes sense to add them.

But yes, adding plots vs BX is a good idea. I have done that as well, for both the jets and the muons.

mtosi · 2017-05-26T07:52:39Z

DQMOffline/Trigger/plugins/NoBPTXMonitor.cc

+
+  // filling histograms (denominator)  
+  // Filter out events if Trigger Filtering is requested
+  if (den_genTriggerEventFlag_->on() && ! den_genTriggerEventFlag_->accept( iEvent, iSetup) ) return;


I would suggest to apply this at the beginning of the function, but ok ....

I have made this change as well.

jalimena · 2017-05-26T11:33:21Z

@mtosi, I think I have responded to all of your questions above, see my latest commit. Please let me know if you think of anything else.

mtosi · 2017-05-26T11:38:57Z

;)

mtosi · 2017-05-26T11:39:19Z

@dmitrijus can we test this PR, please ?
thanks !

dmitrijus · 2017-05-26T14:25:18Z

please test

cmsbuild · 2017-05-26T14:25:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20139/console Started: 2017/05/26 16:26

cmsbuild · 2017-05-26T16:04:16Z

+1
Tested at: a96b7c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18950/20139/summary.html

cmsbuild · 2017-05-26T16:04:19Z

Comparison job queued.

cmsbuild · 2017-05-26T18:23:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18950/20139/summary.html

Comparison Summary:

You potentially added 255 lines to the logs
Reco comparison results: 3381 differences found in the comparisons
DQMHistoTests: Total files compared: 24
DQMHistoTests: Total histograms compared: 1833592
DQMHistoTests: Total failures: 34779
DQMHistoTests: Total nulls: 65
DQMHistoTests: Total successes: 1798568
DQMHistoTests: Total skipped: 180
DQMHistoTests: Total Missing objects: 0
Checked 98 log files, 14 edm output root files, 24 DQM output files

mtosi · 2017-05-29T10:59:31Z

DQMOffline/Trigger/python/NoBPTXMonitor_cff.py

+
+hltNoBPTXMuonsMonitoring = hltNoBPTXmonitoring.clone()
+hltNoBPTXMuonsMonitoring.FolderName = cms.string('HLT/NoBPTX/Muons/')
+hltNoBPTXMuonsMonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_L2Mu40_NoVertex_3Sta_NoBPTX3BX_v*") #HLT_ZeroBias_v*


what about
HLT_L2Mu45_NoVertex_3Sta_NoBPTX3BX
?

Sorry I didn't see this comment and your one below until now, Mia. My latest commit should add the two backup paths.

mtosi · 2017-05-29T10:59:44Z

DQMOffline/Trigger/python/NoBPTXMonitor_cfi.py

+#hltNoBPTXmonitoring.numGenericTriggerEventPSet.dbLabel       = cms.string("ExoDQMTrigger") # it does not exist yet, we should consider the possibility of using the DB, but as it is now it will need a label per path !                                                                                                           
+hltNoBPTXmonitoring.numGenericTriggerEventPSet.andOrHlt      = cms.bool(True)# True:=OR; False:=AND 
+hltNoBPTXmonitoring.numGenericTriggerEventPSet.hltInputTag   = cms.InputTag( "TriggerResults::HLT" )
+hltNoBPTXmonitoring.numGenericTriggerEventPSet.hltPaths      = cms.vstring("HLT_UncorrectedJetE60_NoBPTX3BX_v*") # HLT_ZeroBias_v*


what about HLT_UncorrectedJetE70_NoBPTX3BX ?

fwyzard · 2017-06-22T10:22:50Z

@cmsbuild, please test

cmsbuild · 2017-06-22T10:23:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20839/console Started: 2017/06/22 12:24

cmsbuild · 2017-06-22T11:36:05Z

+1
Tested at: f48928f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18950/20839/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4bfcf97
1c5bd71
8730b28
259c301
4e50f86
d0a212b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18950/20839/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18950/20839/git-merge-result

cmsbuild · 2017-06-22T11:36:08Z

Comparison job queued.

cmsbuild · 2017-06-22T13:12:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18950/20839/summary.html

Comparison Summary:

You potentially added 15 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1802882
DQMHistoTests: Total failures: 44271
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1758445
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

jalimena · 2017-06-23T07:34:23Z

So the tests have now run successfully (thanks @fwyzard !). I think everyone was about to sign before. Can you do so again, @dmitrijus and @davidlange6 ?

dmitrijus · 2017-06-23T13:45:47Z

+1

cmsbuild · 2017-06-23T13:46:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-06-24T12:26:54Z

+1

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

add offline DQM for NoBPTX EXO triggers

b214dbe

cmsbuild added this to the CMSSW_9_2_X milestone May 25, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels May 25, 2017

mtosi reviewed May 26, 2017

View reviewed changes

add histograms vs eta, phi, BX

a96b7c2

cmsbuild added tests-started and removed tests-pending labels May 26, 2017

cmsbuild added tests-approved and removed tests-started labels May 26, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 26, 2017

mtosi reviewed May 29, 2017

View reviewed changes

add monitoring of backup paths

ff45647

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jun 22, 2017

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2017

cmsbuild added tests-approved and removed tests-started labels Jun 22, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jun 22, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 23, 2017

cmsbuild added orp-approved and removed orp-pending labels Jun 24, 2017

cmsbuild merged commit 1d69630 into cms-sw:master Jun 24, 2017

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add offline DQM for NoBPTX EXO triggers #18950

add offline DQM for NoBPTX EXO triggers #18950

jalimena commented May 25, 2017

jalimena commented May 25, 2017

cmsbuild commented May 25, 2017

mtosi May 26, 2017

mtosi May 26, 2017

jalimena May 26, 2017

mtosi May 26, 2017

mtosi May 26, 2017

jalimena May 26, 2017

mtosi May 26, 2017

jalimena May 26, 2017

jalimena commented May 26, 2017

mtosi commented May 26, 2017

mtosi commented May 26, 2017

dmitrijus commented May 26, 2017

cmsbuild commented May 26, 2017 •

edited

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

mtosi May 29, 2017

jalimena May 31, 2017

mtosi May 29, 2017

fwyzard commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 •

edited

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

jalimena commented Jun 23, 2017

dmitrijus commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

davidlange6 commented Jun 24, 2017

add offline DQM for NoBPTX EXO triggers #18950

add offline DQM for NoBPTX EXO triggers #18950

Conversation

jalimena commented May 25, 2017

jalimena commented May 25, 2017

cmsbuild commented May 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jalimena commented May 26, 2017

mtosi commented May 26, 2017

mtosi commented May 26, 2017

dmitrijus commented May 26, 2017

cmsbuild commented May 26, 2017 • edited

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

cmsbuild commented May 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fwyzard commented Jun 22, 2017

cmsbuild commented Jun 22, 2017 • edited

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

cmsbuild commented Jun 22, 2017

jalimena commented Jun 23, 2017

dmitrijus commented Jun 23, 2017

cmsbuild commented Jun 23, 2017

davidlange6 commented Jun 24, 2017

cmsbuild commented May 26, 2017 •

edited

cmsbuild commented Jun 22, 2017 •

edited