Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFormats/PatCandidates : missing #include <array> found compiling on macos with clang #18973

Merged
merged 1 commit into from May 27, 2017
Merged

DataFormats/PatCandidates : missing #include <array> found compiling on macos with clang #18973

merged 1 commit into from May 27, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented May 26, 2017

<array> is indirectly included using gcc on linux. Using clang on macOS this must be explicitly included.

@gartung
Copy link
Member Author

gartung commented May 26, 2017

@Dr15Jones

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

DataFormats/PatCandidates

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@gpetruc, @gouskos, @cbernet this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 26, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20146/console Started: 2017/05/26 20:32

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18973/20146/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3348 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 1833592
  • DQMHistoTests: Total failures: 48963
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1784449
  • DQMHistoTests: Total skipped: 180
  • DQMHistoTests: Total Missing objects: 0
  • Checked 98 log files, 14 edm output root files, 24 DQM output files

@slava77
Copy link
Contributor

slava77 commented May 27, 2017

+1

for #18973 ad8747d

  • technical
  • jenkins tests pass

@davidlange6 davidlange6 merged commit 3170120 into cms-sw:master May 27, 2017
@gartung gartung deleted the DataFormats-PatCandidates-osx-include-array branch May 30, 2017 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants