Updates to pixel phase 1 summary class #18993

leggat · 2017-05-29T10:23:08Z

Addition of new methods for plotting trend plots:

bookTrendPlots(iBooker) allows booking of trend plots
fillTrendPlots(iBooker,iGetter,int lumiSec) allows the filling of trend plots. In the case of offline running the lumiSec should be given as -1. This allows special cases for differing plots between online and offline.
Dead and inefficient ROC monitoring are the first trend plots to be included.

In addition three changes have made to the summary maps:

Grand summary is now in the EventInfo directory to be automatically collected by the GUI.
Bins are now filled with percentage of modules that pass the quality test rather than the simple 'warning' and 'error' previously.
Protection against not booking/accessing empty MEs added

…nd made updates to summary maps. Grand summary now made in eventInfo folder for automatic GUI purposes, and bins now filled with percentage failing QTests instead of simply warnings/errors.

cmsbuild · 2017-05-29T10:23:30Z

A new Pull Request was created by @leggat for master.

It involves the following packages:

DQM/SiPixelPhase1Summary

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

… against not booking plots in the dqmEndLuminosityBlock method

vanbesien · 2017-05-30T07:30:32Z

please test

cmsbuild · 2017-05-30T07:30:49Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20172/console Started: 2017/05/30 09:31

cmsbuild · 2017-05-30T08:45:29Z

+1
Tested at: e97dbe5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18993/20172/summary.html

cmsbuild · 2017-05-30T08:45:32Z

Comparison job queued.

davidlange6 · 2017-05-30T09:37:37Z

DQM/SiPixelPhase1Summary/src/SiPixelPhase1Summary.cc


  std::vector<std::string> xAxisLabels_ = {"BMO","BMI","BPO ","BPI","HCMO_1","HCMO_2","HCMI_1","HCMI_2","HCPO_1","HCPO_2","HCPI_1","HCPI_2"}; // why not having a global variable !?!?!?! 
-  std::vector<std::string> yAxisLabels_ = {"1","2","3","4"}; // why not having a global variable ?!?!?!!?
+  std::vector<std::string> yAxisLabels_ = {"1","2","3","4"}; // why not having a global variable ?!?!?!!? - I originally did, but was told not to by David Lange!


first link on google might be informative - google can tell you more about why to avoid using globals in c++ (let alone a multiply threaded c++)
http://www.cplusplus.com/forum/general/76476/

dmitrijus · 2017-05-30T09:48:48Z

+1

cmsbuild · 2017-05-30T09:49:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-05-30T10:16:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18993/20172/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18993/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D10_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D10+RecoFullGlobal_2023D10+HARVESTFullGlobal_2023D10
/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18993/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D18_GenSimHLBeamSpotFull14+DigiFull_2023D18+RecoFullGlobal_2023D18+HARVESTFullGlobal_2023D18
/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18993/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFull_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3397 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1786103
DQMHistoTests: Total failures: 19318
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1766612
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

davidlange6 · 2017-05-31T07:53:37Z

DQM/SiPixelPhase1Summary/interface/SiPixelPhase1Summary.h

@@ -69,10 +70,20 @@

       std::map<std::string,std::string> summaryPlotName_;

+       //The dead and innefficient roc trend plot
+       std::map<std::string,MonitorElement*>  deadROCTrends_;


Hi @leggat - please change these to be std::map<enum,MonitorElement*> to avoid all the string lookups below. (where you should define a set of enums to meet your needs) [best to do this also with the key to summaryPlotName_] Thanks

Hi @davidlange6 - I've changed the deadROCTrends_ and ineffROCTrends_ as you suggest, but I don't immediately see how this would work for summaryPlotName_ since both the key and value are configurable strings passed from the SiPixelPhase1Summary_cfi.py config file. I don't know where I'd start in changing that...

davidlange6 · 2017-05-31T07:55:41Z

DQM/SiPixelPhase1Summary/src/SiPixelPhase1Summary.cc

+//------------------------------------------------------------------
+void SiPixelPhase1Summary::fillTrendPlots(DQMStore::IBooker & iBooker, DQMStore::IGetter & iGetter, int lumiSec){
+
+  // If we're running in online mode and the lumi section is not modulo 10, return. Offline running always uses lumiSec=0, so it will pass this test.


I don't really understand this comment. why is lumiSec=0 always? (lumiSec seems to be defined as lumiSeg.id().luminosityBlock();

ah - the magic is in if (runOnEndJob_)... got it.

cmsbuild · 2017-05-31T12:11:06Z

Pull request #18993 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

dmitrijus · 2017-05-31T15:07:33Z

+1

cmsbuild · 2017-05-31T15:07:51Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20251/console Started: 2017/05/31 17:08

cmsbuild · 2017-05-31T15:07:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-05-31T18:10:46Z

+1
Tested at: 483e447
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18993/20251/summary.html

cmsbuild · 2017-05-31T18:10:49Z

Comparison job queued.

cmsbuild · 2017-05-31T22:08:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18993/20251/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18993/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D10_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D10+RecoFullGlobal_2023D10+HARVESTFullGlobal_2023D10
/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18993/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D18_GenSimHLBeamSpotFull14+DigiFull_2023D18+RecoFullGlobal_2023D18+HARVESTFullGlobal_2023D18
/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-18993/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFull_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 1698 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1786069
DQMHistoTests: Total failures: 41342
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1744554
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

davidlange6 · 2017-06-01T07:53:19Z

+1

leggat added 2 commits May 29, 2017 12:00

Pixel phase 1 summary updates: Added in dead/innef roc trend plots, a…

ad2291a

…nd made updates to summary maps. Grand summary now made in eventInfo folder for automatic GUI purposes, and bins now filled with percentage failing QTests instead of simply warnings/errors.

Removing the bit I commented out saying I would remove it later

90d6323

cmsbuild added this to the CMSSW_9_2_X milestone May 29, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels May 29, 2017

Adding in protection against attempts to access a non-existent ME and…

e97dbe5

… against not booking plots in the dqmEndLuminosityBlock method

cmsbuild added tests-started and removed tests-pending labels May 30, 2017

cmsbuild added tests-approved and removed tests-started labels May 30, 2017

davidlange6 reviewed May 30, 2017

View reviewed changes

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 30, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 30, 2017

davidlange6 reviewed May 31, 2017

View reviewed changes

cmsbuild added comparison-pending dqm-pending pending-signatures tests-pending and removed comparison-available dqm-approved fully-signed tests-approved labels May 31, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 31, 2017

cmsbuild added tests-started and removed tests-pending labels May 31, 2017

cmsbuild added tests-approved and removed tests-started labels May 31, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 31, 2017

cmsbuild added orp-approved and removed orp-pending labels Jun 1, 2017

cmsbuild merged commit 7a95f7e into cms-sw:master Jun 1, 2017

leggat mentioned this pull request Jun 23, 2017

ROC counting trend plots per layer/ring for phase 1 pixel DQM #19414

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to pixel phase 1 summary class #18993

Updates to pixel phase 1 summary class #18993

leggat commented May 29, 2017 •

edited

cmsbuild commented May 29, 2017

vanbesien commented May 30, 2017

cmsbuild commented May 30, 2017 •

edited

cmsbuild commented May 30, 2017

cmsbuild commented May 30, 2017

davidlange6 May 30, 2017

dmitrijus commented May 30, 2017

cmsbuild commented May 30, 2017

cmsbuild commented May 30, 2017

davidlange6 May 31, 2017

leggat May 31, 2017

davidlange6 May 31, 2017

davidlange6 May 31, 2017

cmsbuild commented May 31, 2017

dmitrijus commented May 31, 2017

cmsbuild commented May 31, 2017 •

edited

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

davidlange6 commented Jun 1, 2017

Updates to pixel phase 1 summary class #18993

Updates to pixel phase 1 summary class #18993

Conversation

leggat commented May 29, 2017 • edited

cmsbuild commented May 29, 2017

vanbesien commented May 30, 2017

cmsbuild commented May 30, 2017 • edited

cmsbuild commented May 30, 2017

cmsbuild commented May 30, 2017

davidlange6 May 30, 2017

Choose a reason for hiding this comment

dmitrijus commented May 30, 2017

cmsbuild commented May 30, 2017

cmsbuild commented May 30, 2017

davidlange6 May 31, 2017

Choose a reason for hiding this comment

leggat May 31, 2017

Choose a reason for hiding this comment

davidlange6 May 31, 2017

Choose a reason for hiding this comment

davidlange6 May 31, 2017

Choose a reason for hiding this comment

cmsbuild commented May 31, 2017

dmitrijus commented May 31, 2017

cmsbuild commented May 31, 2017 • edited

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

davidlange6 commented Jun 1, 2017

leggat commented May 29, 2017 •

edited

cmsbuild commented May 30, 2017 •

edited

cmsbuild commented May 31, 2017 •

edited