GenJetFlavourInfos in MiniAOD and Change in JetFlavour of LightJets to physicsPartons in CMSSW 92X #19048

Andrej-CMS · 2017-05-31T18:59:17Z

Dear all, @arizzi

This PR introduces two changes to the MiniAODSim format.

The GenJetFlavourInfoPreserver tool passes the GenJetFlavour information of the original AK4GenJets in the AODSim to the slimmedGenJets in the MiniAODSim. The new GenJetFlavour information is called "slimmedGenJetsFlavourInfos" and is stored in the MiniAOD. This collection is of the class reco::JetFlavourInfoMatchingCollection and the object consists out of a pair of refvectors.
For the case where no heavy flavour hadron is clustered into the GenJet, a definition based on the "physicsPartons" is chosen. physicsPartons now contain the full shower. Changes were proposed by the QGL group.

Kind regards,

Andrej

…he original AK4GenJets(AOD) to the slimmedGenJets (MiniAOD)

…niAOD

…hadron in the jet is chosen as the flavour hadron

cmsbuild · 2017-05-31T18:59:37Z

A new Pull Request was created by @Andrej-CMS for master.

It involves the following packages:

PhysicsTools/JetMCAlgos
PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

slava77 · 2017-05-31T19:35:02Z

@cmsbuild please test

cmsbuild · 2017-05-31T19:35:22Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20266/console Started: 2017/05/31 21:36

cmsbuild · 2017-05-31T21:02:27Z

+1
Tested at: ea57cff
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19048/20266/summary.html

cmsbuild · 2017-05-31T21:02:30Z

Comparison job queued.

cmsbuild · 2017-05-31T22:59:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19048/20266/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3240 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1786072
DQMHistoTests: Total failures: 48698
DQMHistoTests: Total nulls: 16
DQMHistoTests: Total successes: 1737185
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

ahinzmann · 2017-06-01T11:04:04Z

@Andrej-CMS Do you have some plots or numbers that show how this changes the flavor composition of the leading jet on a RelVal sample (e.g. z+jets should have ~60% quarks, qcd should have 50-70% gluons)?

monttj · 2017-06-02T14:25:06Z

PhysicsTools/JetMCAlgos/plugins/HadronAndPartonSelector.cc

@@ -254,7 +254,7 @@ HadronAndPartonSelector::produce(edm::Event& iEvent, const edm::EventSetup& iSet
     partonSelector_->run(particles,partons);
     for(reco::GenParticleCollection::const_iterator it = particles->begin(); it != particles->end(); ++it)
     {
-       if( !(it->status()==3 || (( partonMode_=="Pythia8" ) && (it->status()==23)))) continue;
+      // if( !(it->status()==3 || (( partonMode_=="Pythia8" ) && (it->status()==23)))) continue;


Dear @Andrej-CMS,

I am wondering if commenting out this has any consequences not only in terms of file size but also in other places where HadronAndSelector is being used.
It is because if I understand correctly, without this condition, this will contain all partons including status 2 and also stable final particles. That will be a lot of particles. This will also introduce ambiguity issue.

Best Regards,
Taejeong

Hello @monttj ,
These changes were requested by the QGL Group, i.e. Paolo Azzuri. Unfortunately, I cannot find him on GitHub to comment on this.

You are right, the physicspartons will contain the whole chain. I will provide RelVal comparisons as soon as possible.

Kind regards,
Andrej

can you make that configurable?

yes, I will do that.

Kind regards,
Andrej

slava77 · 2017-06-05T13:18:09Z

Please note: this PR will not be merged until some validation plots/slides are provided.

slava77 · 2017-06-07T14:35:01Z

PhysicsTools/JetMCAlgos/plugins/HadronAndPartonSelector.cc

@@ -254,7 +254,7 @@ HadronAndPartonSelector::produce(edm::Event& iEvent, const edm::EventSetup& iSet
     partonSelector_->run(particles,partons);
     for(reco::GenParticleCollection::const_iterator it = particles->begin(); it != particles->end(); ++it)
     {
-       if( !(it->status()==3 || (( partonMode_=="Pythia8" ) && (it->status()==23)))) continue;
+      // if( !(it->status()==3 || (( partonMode_=="Pythia8" ) && (it->status()==23)))) continue;


it looks like this part will be modified to become configurable.
If it would not, the following applies:
is this commented out code needed?
Please remove or add comments inline in the code why the commented out block is relevant

slava77 · 2017-06-07T14:40:57Z

PhysicsTools/JetMCAlgos/python/AK4PFJetsMCFlavourInfos_cfi.py

@@ -4,7 +4,7 @@
    jets                     = cms.InputTag("ak4PFJets"),
    bHadrons                 = cms.InputTag("selectedHadronsAndPartons","bHadrons"),
    cHadrons                 = cms.InputTag("selectedHadronsAndPartons","cHadrons"),
-    partons                  = cms.InputTag("selectedHadronsAndPartons","algorithmicPartons"),
+    partons                  = cms.InputTag("selectedHadronsAndPartons","physicsPartons"),


should the same be applied to other available instances of JetFlavourClustering in this package?
There is one in AK5

cmsbuild · 2017-08-12T19:32:32Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19048/22256/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2713569
DQMHistoTests: Total failures: 276
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2713104
DQMHistoTests: Total skipped: 189
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 14 edm output root files, 26 DQM output files

slava77 · 2017-08-13T02:46:31Z

I'm looking at the changes:
(this it a ttbar sample no PU for 2017 setup)

shouldn't there be something between 1 and 3 in this variable?

the parton flavor apparently covers the relevant range

ahinzmann · 2017-08-14T08:01:02Z

@slava77 Hadron flavour only looks for B-hadrons, thus cannot detect light quarks.

slava77 · 2017-08-14T12:57:56Z

+1

for #19048 19314ca

changes are in line with the description
jenkins tests pass and comparisons with baseline show differences only in /JetValidation/slimmedJets PartonFlavor as expected
local tests to compare new variables show expected behavior
- the variables in the new product slimmedGenJetsFlavourInfos look as expected as can be seen in plots posted earlier e.g. GenJetFlavourInfos in MiniAOD and Change in JetFlavour of LightJets to physicsPartons in CMSSW 92X #19048 (comment)
- slimmedGenJetsFlavourInfos product takes about 330 bytes (based on 3K events processed)
- CPU use increased by an acceptably small amount from addition of new modules by about 6ms/evt, compared to about 1.6 s/evt total.

slava77 · 2017-08-15T13:37:50Z

@dmitrijus @monttj
dqm and analysis signatures are needed for this PR.
Please check and sign or suggest changes.

slava77 · 2017-08-16T12:26:01Z

@dmitrijus @monttj
dqm and analysis signatures are needed for this PR.
Please check and sign or suggest changes.
Thank you.

slava77 · 2017-08-17T13:53:07Z

@dmitrijus @monttj
dqm and analysis signatures are needed for this PR.
Please check and sign or suggest changes.
Thank you.

@davidlange6 please check.

slava77 · 2017-08-21T14:11:57Z

to continue my weekdaily ping

@dmitrijus @monttj
dqm and analysis signatures are needed for this PR.
Please check and sign or suggest changes.
Thank you.

@davidlange6 please check.

slava77 · 2017-08-22T13:22:47Z

code-checks

the last checks went outside of the scope of the PR

cmsbuild · 2017-08-22T13:29:43Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-19048/246

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-19048/246/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/PR-19048/246/git-diff.patch | patch -p1

In future, you can run scram build code-checks to apply code checks

slava77 · 2017-08-22T14:14:07Z

to continue my weekdaily ping on day 8 after no activity

@dmitrijus @monttj
dqm and analysis signatures are needed for this PR.

@davidlange6 please check and merge with missing signatures or suggest changes.
Thank you.

dmitrijus · 2017-08-23T09:10:44Z

+1

slava77 · 2017-08-25T16:30:47Z

@davidlange6 please check and merge with missing AT signature or suggest changes.

Thank you.

davidlange6 · 2017-08-25T16:37:26Z

merge

davidlange6 · 2017-08-28T08:41:04Z

PhysicsTools/PatAlgos/plugins/GenJetFlavourInfoPreserver.cc

+    edm::Ref<std::vector<reco::GenJet> > slimmedGenJetRef;
+
+    int i = -1;
+    for (auto const& genJet : *genJets){


hi @Andrej-CMS @slava77 @perrotta - this brings a warning as genJet is not actually used. Please change to a loop over i if genJets->refAt(i) is not the same as genJet in the loop below

Hello @davidlange6 ,

I just pushed the changes to the initial branch on my repository: https://github.com/Andrej-CMS/cmssw/tree/JetFlavourMiniAOD92X

Since the changes here are already merged, do I need to make a new PR?

Kind regards,
Andrej

davidlange6 · 2017-08-28T10:07:08Z

yes, it would need a new PR. Thanks!

…

I just pushed the changes to the initial branch on my repository: https://github.com/Andrej-CMS/cmssw/tree/JetFlavourMiniAOD92X Since the changes here are already merged, do I need to make a new PR? Kind regards, Andrej — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Andrej-CMS added 5 commits May 31, 2017 19:34

GenJetFlavourInfoPreserver: Tool to transfer the JetFlavourInfos of t…

ca2abcf

…he original AK4GenJets(AOD) to the slimmedGenJets (MiniAOD)

Changes made in order to write the slimmedGenJetsFlavourInfos into Mi…

649dfa8

…niAOD

If no heavy flavour hadron is associated with the gen-jet, the maxPt …

0f4b578

…hadron in the jet is chosen as the flavour hadron

physicsPartons now contain the full shower. As proposed by the QGL group

9a6d45d

Cleaned up code

ea57cff

cmsbuild added this to the CMSSW_9_2_X milestone May 31, 2017

cmsbuild added analysis-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 31, 2017

Andrej-CMS mentioned this pull request May 31, 2017

GenJetFlavourInfos in MiniAOD and Change in JetFlavour of LightJets to physicsPartons in CMSSW 80X #19049

Closed

cmsbuild added tests-started and removed tests-pending labels May 31, 2017

cmsbuild added tests-approved and removed tests-started labels May 31, 2017

cmsbuild added comparison-available and removed comparison-pending labels May 31, 2017

monttj reviewed Jun 2, 2017

View reviewed changes

slava77 reviewed Jun 7, 2017

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Aug 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Aug 12, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 14, 2017

smuzaffar added the code-checks-rejected label Aug 22, 2017

gpetruc mentioned this pull request Aug 22, 2017

Adding reduced GsfTracks to miniAOD #19964

Merged

cmsbuild added dqm-approved and removed dqm-pending labels Aug 23, 2017

cmsbuild merged commit c61529f into cms-sw:master Aug 25, 2017

davidlange6 reviewed Aug 28, 2017

View reviewed changes

Andrej-CMS mentioned this pull request Aug 28, 2017

GenJetFlavourInfos: fix compiler warning, use prunedGenParticles in associations to correctly match pat jet flavour info #20281

Merged

ahinzmann mentioned this pull request Oct 9, 2017

MiniAOD: use all genParticles for patJets partonFlavour #20840

Merged

arizzi mentioned this pull request Oct 11, 2017

Objects from Rivet-based ParticleLevelProducer cms-nanoAOD/cmssw#21

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GenJetFlavourInfos in MiniAOD and Change in JetFlavour of LightJets to physicsPartons in CMSSW 92X #19048

GenJetFlavourInfos in MiniAOD and Change in JetFlavour of LightJets to physicsPartons in CMSSW 92X #19048

Andrej-CMS commented May 31, 2017

cmsbuild commented May 31, 2017

slava77 commented May 31, 2017

cmsbuild commented May 31, 2017 •

edited

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

ahinzmann commented Jun 1, 2017

monttj Jun 2, 2017

Andrej-CMS Jun 7, 2017

arizzi Jun 7, 2017

Andrej-CMS Jun 7, 2017

slava77 commented Jun 5, 2017

slava77 Jun 7, 2017

slava77 Jun 7, 2017

cmsbuild commented Aug 12, 2017

slava77 commented Aug 13, 2017

ahinzmann commented Aug 14, 2017

slava77 commented Aug 14, 2017

slava77 commented Aug 15, 2017

slava77 commented Aug 16, 2017

slava77 commented Aug 17, 2017

slava77 commented Aug 21, 2017

slava77 commented Aug 22, 2017

cmsbuild commented Aug 22, 2017

slava77 commented Aug 22, 2017

dmitrijus commented Aug 23, 2017

slava77 commented Aug 25, 2017

davidlange6 commented Aug 25, 2017

davidlange6 Aug 28, 2017

Andrej-CMS Aug 28, 2017

davidlange6 commented Aug 28, 2017 via email

GenJetFlavourInfos in MiniAOD and Change in JetFlavour of LightJets to physicsPartons in CMSSW 92X #19048

GenJetFlavourInfos in MiniAOD and Change in JetFlavour of LightJets to physicsPartons in CMSSW 92X #19048

Conversation

Andrej-CMS commented May 31, 2017

cmsbuild commented May 31, 2017

slava77 commented May 31, 2017

cmsbuild commented May 31, 2017 • edited

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

cmsbuild commented May 31, 2017

ahinzmann commented Jun 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slava77 commented Jun 5, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmsbuild commented Aug 12, 2017

slava77 commented Aug 13, 2017

ahinzmann commented Aug 14, 2017

slava77 commented Aug 14, 2017

slava77 commented Aug 15, 2017

slava77 commented Aug 16, 2017

slava77 commented Aug 17, 2017

slava77 commented Aug 21, 2017

slava77 commented Aug 22, 2017

cmsbuild commented Aug 22, 2017

slava77 commented Aug 22, 2017

dmitrijus commented Aug 23, 2017

slava77 commented Aug 25, 2017

davidlange6 commented Aug 25, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davidlange6 commented Aug 28, 2017 via email

cmsbuild commented May 31, 2017 •

edited