Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommonTools/RecoUtils : fix gcc700 warning: class has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] #19074

Merged
merged 1 commit into from Jun 2, 2017

Conversation

gartung
Copy link
Member

@gartung gartung commented Jun 1, 2017

Fixes warnings like these by adding virtual destructor with default constructor.

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/cad3eea82b17ccf34f572f7928d21ee1/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-28-2300/src/CommonTools/RecoUtils/interface/PF_PU_AssoMapAlgos.h:82:7: warning: 'class PF_PU_AssoMapAlgos' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor]

/build/cmsbld/jenkins-workarea/workspace/build-any-ib/w/tmp/BUILDROOT/cad3eea82b17ccf34f572f7928d21ee1/opt/cmssw/slc6_amd64_gcc700/cms/cmssw/CMSSW_9_2_X_2017-05-28-2300/src/CommonTools/RecoUtils/interface/PF_PU_AssoMap.h:41:7: warning: base class 'class PF_PU_AssoMapAlgos' has accessible non-virtual destructor [-Wnon-virtual-dtor]

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

CommonTools/RecoUtils

@cmsbuild, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jun 1, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20293/console Started: 2017/06/01 21:40

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19074/20293/summary.html

Comparison Summary:

  • You potentially added 150 lines to the logs
  • Reco comparison results: 3452 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1789234
  • DQMHistoTests: Total failures: 62525
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1726536
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@monttj
Copy link
Contributor

monttj commented Jun 2, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit de326c6 into cms-sw:master Jun 2, 2017
@gartung gartung deleted the CommonTools-gcc700-dtor-warning-fix branch September 27, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants