Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HcalDbASCIIIO template specializations #19096

Merged
merged 1 commit into from Jun 8, 2017

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Jun 5, 2017

The template specializations added to HcalDbASCIIIO in #18556 need to be forward-declared so the compiler won't ignore them.

@kpedro88
Copy link
Contributor Author

kpedro88 commented Jun 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20330/console Started: 2017/06/05 17:28

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

CalibCalorimetry/HcalAlgos

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19096/20330/summary.html

Comparison Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 1727 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837605
  • DQMHistoTests: Total failures: 56843
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1780589
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jun 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3deb40f into cms-sw:master Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants