Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tech.fix: extending dumping precision for Gains #19101

Merged
merged 1 commit into from Jun 8, 2017

Conversation

abdoulline
Copy link

@abdoulline abdoulline commented Jun 6, 2017

Actual (limited) dumping precision may not be sufficient for the future SiPMs gains considerations.
This is a transparent 1-line fix. Tested with available DB conditions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

CalibCalorimetry/HcalAlgos

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mariadalfonso, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jun 7, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20397/console Started: 2017/06/07 14:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19101/20397/summary.html

Comparison Summary:

  • You potentially added 170 lines to the logs
  • Reco comparison results: 1720 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837717
  • DQMHistoTests: Total failures: 43146
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1794398
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Jun 8, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e933dfd into cms-sw:master Jun 8, 2017
@abdoulline abdoulline deleted the fix_dump_Gains branch April 17, 2018 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants