Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add include for Trajectory.h to TrajGsfTrackAssociation.h #19108

Merged
merged 1 commit into from Jun 8, 2017
Merged

Add include for Trajectory.h to TrajGsfTrackAssociation.h #19108

merged 1 commit into from Jun 8, 2017

Conversation

Teemperor
Copy link
Contributor

We use the Trajectory class in this header, but we didn't include
the relevant header, which prevents this header from compiling.

@Teemperor
Add include for Trajectory.h to TrajGsfTrackAssociation.h
9b0c877 
We use the Trajectory class in this header, but we didn't include
the relevant header, which prevents this header from compiling.
@cmsbuild cmsbuild added this to the CMSSW_9_2_X milestone Jun 6, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

TrackingTools/GsfTracking

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20354/console Started: 2017/06/06 15:09

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

-1

Tested at: 9b0c877

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2a0d176
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19108/20354/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19108/20354/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19108/20354/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2017 --magField 38T_PostLS1 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Tue Jun 6 16:26:07 2017-date Tue Jun 6 16:17:21 2017 s - exit: 21760

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2a0d176
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19108/20354/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19108/20354/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19108/20354/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1646 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837639
  • DQMHistoTests: Total failures: 23449
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1814017
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@Teemperor Teemperor mentioned this pull request Jun 7, 2017
Closed
@perrotta
Copy link
Contributor

perrotta commented Jun 7, 2017

please test
(previous failure due to eos issue)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20393/console Started: 2017/06/07 11:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

+1
Tested at: 9b0c877
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19108/20393/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19108/20393/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3421 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837609
  • DQMHistoTests: Total failures: 62565
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1774871
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jun 8, 2017

+1

  • Techincal
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4a58f75 into cms-sw:master Jun 8, 2017
@Teemperor Teemperor deleted the FixMissingIncludesTrajGsfTrackAssociation.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the FixMissingIncludesTrajGsfTrackAssociation.h branch December 19, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Teemperor @cmsbuild @perrotta @davidlange6