Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from CalibTracker ESSource provider #19116

Merged
merged 1 commit into from Jun 7, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 6, 2017

This instance of PoolDBESSource is used in an handful of configuration files in the Alignment and CalibTracker areas: see gitHub.
Modernizing the configuration to avoid the annoying disclaimer about the deprecated module.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/Configuration

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @gbenelli, @tocheng, @jlagram this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Jun 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20378/console Started: 2017/06/06 21:54

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19116/20378/summary.html

Comparison Summary:

  • You potentially added 57 lines to the logs
  • Reco comparison results: 3402 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1837605
  • DQMHistoTests: Total failures: 47365
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1790067
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@franzoni
Copy link

franzoni commented Jun 7, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit da4f0a6 into cms-sw:master Jun 7, 2017
@mmusich mmusich deleted the 92X_fixCalibTrackerCommonWarning branch June 27, 2017 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants