Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing includes to PFEcalEndcapRecHitCreator.h #19158

Merged

Conversation

Teemperor
Copy link
Contributor

We use the EESrFlagCollection in this header, so we also need to
include EcalDigiCollections.h which defines this.

The eTTmap_ member is also of the type EcalTrigTowerConstituentsMap,
so we need to include EcalTrigTowerConstituentsMap.h.

We use the EESrFlagCollection in this header, so we also need to
include EcalDigiCollections.h which defines this.

The eTTmap_ member is also of the type EcalTrigTowerConstituentsMap,
so we need to include EcalTrigTowerConstituentsMap.h.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding issue #15248

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @rafaellopesdesa, @lgray, @seemasharmafnal, @cbernet, @bachtis this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jun 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20446/console Started: 2017/06/09 12:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19158/20446/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1872255
  • DQMHistoTests: Total failures: 35020
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1837062
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jun 9, 2017

+1

for #19158 e27af47

  • technical
  • jenkins tests pass (Reco comparison results: 0 differences found in the comparisons)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d456a4d into cms-sw:master Jun 10, 2017
@Teemperor Teemperor deleted the FixIncludesPFEcalEndcapRecHitCreator.h branch December 19, 2017 08:47
@Teemperor Teemperor restored the FixIncludesPFEcalEndcapRecHitCreator.h branch December 19, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants