Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix needed by classes derived from virtual jet producer #19163

Merged

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Jun 9, 2017

bug-fix of #19098

This should fix the errors in the HI Jet Producers which inherits from VirtualJetProducer by:

  • adding the missing parameters in the fillDescription() method of the base class;
  • restoring the local src_ variable in VirtualJetProducer, which is needed in the derived classes

@alefisico @Martin-Grunewald @fwyzard @silviodonato

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @ahinzmann, @rappoccio, @yslai, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Jun 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20444/console Started: 2017/06/09 12:35

@perrotta
Copy link
Contributor Author

perrotta commented Jun 9, 2017

type bug-fix

@perrotta perrotta changed the title Fix classes derived from virtual jet producer Fix needed by classes derived from virtual jet producer Jun 9, 2017
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19163/20444/summary.html

Comparison Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1872255
  • DQMHistoTests: Total failures: 5282
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1866800
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@perrotta
Copy link
Contributor Author

perrotta commented Jun 9, 2017

+1
Bug fix tested (also) with HI wfs 301 and 302

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 14fd250 into cms-sw:master Jun 9, 2017
@perrotta perrotta deleted the fixClassesDerivedFromVirtualJetProducer branch July 11, 2017 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants