Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix includes and forward declarations #19170

Merged
merged 1 commit into from Jun 10, 2017

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jun 9, 2017

This Pr substitutes #19124, #19125, #19126

Added missing includes and forward declarations.
Remaining auto_ptr substituted by unique_ptr.
Should not affect results.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4CMS/Forward
SimG4CMS/HcalTestBeam
SimG4Core/Physics

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Jun 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20459/console Started: 2017/06/09 16:56

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@civanch
Copy link
Contributor Author

civanch commented Jun 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19170/20459/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1872255
  • DQMHistoTests: Total failures: 5273
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1866809
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d99fa55 into cms-sw:master Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants