Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-hcx133 Fix a bug which caused crash in HcalGeometry #19172

Merged
merged 2 commits into from Jun 10, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jun 9, 2017

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloTopology

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 9, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20460/console Started: 2017/06/09 16:58

@davidlange6
Copy link
Contributor

ah - another off by one problem in this code.. i guess we don't see this in MC because it is consistently "off by one" in the SIM step and the RECO step?

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 9, 2017

@bsunanda while I was looking at this, I noticed what I think is another bug:
https://github.com/cms-sw/cmssw/blob/CMSSW_9_2_1/Geometry/HcalTowerAlgo/src/HcalGeometry.cc#L99

 } else if (m_topology.etaMax(HcalEndcap) ) {

I think this should be:

 } else if (abseta <= m_topology.etaMax(HcalEndcap) ) {

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 9, 2017

I confirm that @bsunanda's fix in this PR resolves the crash in run 296173 event 290132990. The bug I noticed is therefore unrelated, but should also be fixed at some point.

@slava77
Copy link
Contributor

slava77 commented Jun 9, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Pull request #19172 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 9, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20470/console Started: 2017/06/09 18:20

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 9, 2017

@slava77 I don't think it will affect Physics quantities. These are pure bug fixes

@davidlange6
Copy link
Contributor

davidlange6 commented Jun 9, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison job queued.

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 9, 2017

I dont know why we did not see it before. It is indeed a precision issue and should have been noticed earlier. It is not a new piece of code either.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19172/20470/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1872289
  • DQMHistoTests: Total failures: 25959
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1846157
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@ianna
Copy link
Contributor

ianna commented Jun 10, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1
strange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants