New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-hcx133 Fix a bug which caused crash in HcalGeometry #19172
Conversation
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/CaloTopology @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
ah - another off by one problem in this code.. i guess we don't see this in MC because it is consistently "off by one" in the SIM step and the RECO step? |
@bsunanda while I was looking at this, I noticed what I think is another bug:
I think this should be:
|
I confirm that @bsunanda's fix in this PR resolves the crash in run 296173 event 290132990. The bug I noticed is therefore unrelated, but should also be fixed at some point. |
On 6/9/17 8:58 AM, Kevin Pedro wrote:
I confirm that @bsunanda <https://github.com/bsunanda>'s fix in this PR
resolves the crash in run 296173 event 290132990. The bug I noticed is
therefore unrelated, but should also be fixed at some point.
since no reco signature is required, and also since I couldn't reproduce
the crash,
this confirmation seems good enough for reco.
do we expect any changes in physics quantities from this PR?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19172 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbodJPd20gMQBx_eLQ2l48jCQcwXxks5sCWurgaJpZM4N1dqk>.
\
|
Comparison job queued. |
Pull request #19172 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
@slava77 I don't think it will affect Physics quantities. These are pure bug fixes |
Comparison job queued. |
I dont know why we did not see it before. It is indeed a precision issue and should have been noticed earlier. It is not a new piece of code either. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
+1 |
No description provided.