Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Xerces Leaked Memory Clean Up" #19210

Merged

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jun 13, 2017

Reverts #19041

reverting a change that broke CTPPS reconstruction

@slava77
Copy link
Contributor Author

slava77 commented Jun 13, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20551/console Started: 2017/06/13 18:57

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

CondFormats/CTPPSReadoutObjects
L1Trigger/L1TMuonOverlap

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @ggovi, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @kreczko, @tocheng, @Martin-Grunewald, @thomreis, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor Author

slava77 commented Jun 13, 2017

@cmsbuild please test

the last set of tests was run "too early": they included both the #19041 and its revert.
Jenkins has since moved to CMSSW_9_2_X_2017-06-13-1200
the goal here is to show CTPPS plots coming back up

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20554/console Started: 2017/06/13 21:26

@davidlange6 davidlange6 merged commit b1314a6 into cms-sw:master Jun 13, 2017
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19210/20554/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1817858
  • DQMHistoTests: Total failures: 34614
  • DQMHistoTests: Total nulls: 10
  • DQMHistoTests: Total successes: 1783068
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants